[Rt-commit] rtfm branch, 2.4/perlcritic, updated. 2.4.3-13-g2f3e721

Alex Vandiver alexmv at bestpractical.com
Thu Jul 7 18:25:24 EDT 2011


The branch, 2.4/perlcritic has been updated
       via  2f3e721ef8b840bbc63576996377fadeecb1f0b2 (commit)
      from  5bbc6d9f62748bdc20391f1e6094e06dc4d97307 (commit)

Summary of changes:
 lib/RT/FM/Article_Overlay.pm |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

- Log -----------------------------------------------------------------
commit 2f3e721ef8b840bbc63576996377fadeecb1f0b2
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Thu Jul 7 18:25:14 2011 -0400

    UNIVERSAL::isa is deprecated; a simple ref() suffices

diff --git a/lib/RT/FM/Article_Overlay.pm b/lib/RT/FM/Article_Overlay.pm
index e308434..48ad25e 100644
--- a/lib/RT/FM/Article_Overlay.pm
+++ b/lib/RT/FM/Article_Overlay.pm
@@ -131,7 +131,7 @@ sub Create {
         foreach my $value (@vals) {
 
             my ( $cfid, $cfmsg ) = $self->_AddCustomFieldValue(
-                (UNIVERSAL::isa( $value => 'HASH' )
+                ( ( ref($value) eq 'HASH' )
                     ? %$value
                     : (Value => $value)
                 ),

-----------------------------------------------------------------------


More information about the Rt-commit mailing list