[Rt-commit] rtir branch, 2.6/perlcritic, updated. 2.6.0-32-g002a651

Alex Vandiver alexmv at bestpractical.com
Thu Jul 7 19:21:42 EDT 2011


The branch, 2.6/perlcritic has been updated
       via  002a651fa26207dddf56fc6d3525c5e5571de099 (commit)
      from  433b009560690dcd15ccb6a7879353393e8f31c7 (commit)

Summary of changes:
 lib/RT/IR/Test.pm |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

- Log -----------------------------------------------------------------
commit 002a651fa26207dddf56fc6d3525c5e5571de099
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Thu Jul 7 19:21:39 2011 -0400

    We can simply "use base" to get the same @ISA effect as manipulating it directly

diff --git a/lib/RT/IR/Test.pm b/lib/RT/IR/Test.pm
index 82ad2be..3bcc4b3 100644
--- a/lib/RT/IR/Test.pm
+++ b/lib/RT/IR/Test.pm
@@ -6,7 +6,6 @@ use lib qw(/opt/rt3/local/lib /opt/rt3/lib);
 
 package RT::IR::Test;
 
-our @ISA;
 BEGIN {
     local $@;
     eval { require RT::Test; 1 } or do {
@@ -16,8 +15,8 @@ BEGIN {
             ."You may need to set PERL5LIB=/path/to/rt/lib"
         );
     };
-    push @ISA, 'RT::Test';
 }
+use base qw(RT::Test);
 
 use RT::IR::Test::Web;
 

-----------------------------------------------------------------------


More information about the Rt-commit mailing list