[Rt-commit] rtfm branch, 2.4/perlcritic, updated. 2.4.3-14-g052290d

Alex Vandiver alexmv at bestpractical.com
Thu Jul 21 17:27:10 EDT 2011


The branch, 2.4/perlcritic has been updated
       via  052290d1229e8aa33e06c400c885540327fd5243 (commit)
      from  2f3e721ef8b840bbc63576996377fadeecb1f0b2 (commit)

Summary of changes:
 lib/RT/FM/Article_Overlay.pm |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

- Log -----------------------------------------------------------------
commit 052290d1229e8aa33e06c400c885540327fd5243
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Thu Jul 21 17:26:56 2011 -0400

    Remove a postfix regex which confuses perlcritic

diff --git a/lib/RT/FM/Article_Overlay.pm b/lib/RT/FM/Article_Overlay.pm
index 48ad25e..c0c4ccb 100644
--- a/lib/RT/FM/Article_Overlay.pm
+++ b/lib/RT/FM/Article_Overlay.pm
@@ -125,7 +125,7 @@ sub Create {
     # {{{ Add custom fields
 
     foreach my $key ( keys %args ) {
-        next unless ( $key =~ /CustomField-(.*)$/ );
+        $key =~ /CustomField-(.*)$/ or next;
         my $cf   = $1;
         my @vals = ref( $args{$key} ) eq 'ARRAY' ? @{ $args{$key} } : ( $args{$key} );
         foreach my $value (@vals) {

-----------------------------------------------------------------------


More information about the Rt-commit mailing list