[Rt-commit] rtfm branch, 2.4/perlcritic, updated. 2.4.3-15-g26d649b

[Alex Vandiver]

The branch, 2.4/perlcritic has been updated
       via  26d649bc8918f7d7a4c0782c06508df8ef292148 (commit)
      from  052290d1229e8aa33e06c400c885540327fd5243 (commit)

Summary of changes:
 lib/RT/FM/Article_Overlay.pm |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

- Log -----------------------------------------------------------------
commit 26d649bc8918f7d7a4c0782c06508df8ef292148
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Thu Jul 21 19:32:28 2011 -0400

    Revert a questionable change which was made due to perlcritic fail
    
    This reverts commit 052290d1229e8aa33e06c400c885540327fd5243.

diff --git a/lib/RT/FM/Article_Overlay.pm b/lib/RT/FM/Article_Overlay.pm
index c0c4ccb..48ad25e 100644
--- a/lib/RT/FM/Article_Overlay.pm
+++ b/lib/RT/FM/Article_Overlay.pm
@@ -125,7 +125,7 @@ sub Create {
     # {{{ Add custom fields
 
     foreach my $key ( keys %args ) {
-        $key =~ /CustomField-(.*)$/ or next;
+        next unless ( $key =~ /CustomField-(.*)$/ );
         my $cf   = $1;
         my @vals = ref( $args{$key} ) eq 'ARRAY' ? @{ $args{$key} } : ( $args{$key} );
         foreach my $value (@vals) {

-----------------------------------------------------------------------