[Rt-commit] rt branch, 3.8/perlcritic, updated. rt-3.8.10-67-g5bff45e

[Thomas Sibley]

The branch, 3.8/perlcritic has been updated
       via  5bff45e96a2fac0cfbdaa9dc325dc2590eaa0ca4 (commit)
      from  2d287dc8f83605f3c0cf340486636a4f58178742 (commit)

Summary of changes:
 lib/RT/Attachment_Overlay.pm            |    2 +-
 lib/RT/ObjectCustomFields_Overlay.pm    |    1 -
 lib/RT/Shredder/Plugin/Attachments.pm   |    1 -
 lib/RT/Shredder/Plugin/Tickets.pm       |    1 -
 lib/RT/Tickets_Overlay.pm               |   10 +---------
 share/html/Admin/Queues/Templates.html  |    2 +-
 share/html/Install/DatabaseDetails.html |    1 -
 7 files changed, 3 insertions(+), 15 deletions(-)

- Log -----------------------------------------------------------------
commit 5bff45e96a2fac0cfbdaa9dc325dc2590eaa0ca4
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Fri Jul 22 16:06:43 2011 -0400

    Remove variables declared but not used

diff --git a/lib/RT/Attachment_Overlay.pm b/lib/RT/Attachment_Overlay.pm
index 5bc4286..feeca28 100644
--- a/lib/RT/Attachment_Overlay.pm
+++ b/lib/RT/Attachment_Overlay.pm
@@ -365,7 +365,7 @@ sub Quote {
     my %args=(Reply=>undef, # Prefilled reply (i.e. from the KB/FAQ system)
 	      @_);
 
-    my ($quoted_content, $body, $headers);
+    my ($body, $headers);
     my $max=0;
 
     # TODO: Handle Multipart/Mixed (eventually fix the link in the
diff --git a/lib/RT/ObjectCustomFields_Overlay.pm b/lib/RT/ObjectCustomFields_Overlay.pm
index 3631a9a..9a4eecd 100644
--- a/lib/RT/ObjectCustomFields_Overlay.pm
+++ b/lib/RT/ObjectCustomFields_Overlay.pm
@@ -100,7 +100,6 @@ sub HasEntryForCustomField {
 
 sub CustomFields {
     my $self = shift;
-    my %seen;
     map { $_->CustomFieldObj } @{$self->ItemsArrayRef};
 }
 
diff --git a/lib/RT/Shredder/Plugin/Attachments.pm b/lib/RT/Shredder/Plugin/Attachments.pm
index ed898cb..69ff7d1 100644
--- a/lib/RT/Shredder/Plugin/Attachments.pm
+++ b/lib/RT/Shredder/Plugin/Attachments.pm
@@ -82,7 +82,6 @@ sub TestArgs
 {
     my $self = shift;
     my %args = @_;
-    my $queue;
     if( $args{'file'} ) {
         unless( $args{'file'} =~ /^[\w\. *?]+$/) {
             return( 0, "Files mask '$args{file}' has invalid characters" );
diff --git a/lib/RT/Shredder/Plugin/Tickets.pm b/lib/RT/Shredder/Plugin/Tickets.pm
index 8b499e3..42b70b8 100644
--- a/lib/RT/Shredder/Plugin/Tickets.pm
+++ b/lib/RT/Shredder/Plugin/Tickets.pm
@@ -90,7 +90,6 @@ sub TestArgs
 {
     my $self = shift;
     my %args = @_;
-    my $queue;
     if( $args{'query'} ) {
         my $objs = RT::Tickets->new( $RT::SystemUser );
         $objs->{'allow_deleted_search'} = 1;
diff --git a/lib/RT/Tickets_Overlay.pm b/lib/RT/Tickets_Overlay.pm
index 97b60e7..bb7008d 100755
--- a/lib/RT/Tickets_Overlay.pm
+++ b/lib/RT/Tickets_Overlay.pm
@@ -1630,7 +1630,6 @@ C<ALIAS> is set to the name of a watcher type.
 sub OrderByCols {
     my $self = shift;
     my @args = @_;
-    my $clause;
     my @res   = ();
     my $order = 0;
 
@@ -2335,14 +2334,7 @@ sub LimitWatcher {
         @_
     );
 
-    #build us up a description
-    my ( $watcher_type, $desc );
-    if ( $args{'TYPE'} ) {
-        $watcher_type = $args{'TYPE'};
-    }
-    else {
-        $watcher_type = "Watcher";
-    }
+    my $watcher_type = $args{'TYPE'} || "Watcher";
 
     $self->Limit(
         FIELD       => $watcher_type,
diff --git a/share/html/Admin/Queues/Templates.html b/share/html/Admin/Queues/Templates.html
index 9e39f48..58a7b74 100755
--- a/share/html/Admin/Queues/Templates.html
+++ b/share/html/Admin/Queues/Templates.html
@@ -59,7 +59,7 @@
 my $QueueObj = RT::Queue->new($session{'CurrentUser'});
 $QueueObj->Load($id);
 
-my ($title, $current_subtab);
+my $title;
 
 if ($QueueObj->id) {
     $title = loc("Edit Templates for queue [_1]", $QueueObj->Name);
diff --git a/share/html/Install/DatabaseDetails.html b/share/html/Install/DatabaseDetails.html
index 904d6b8..23e13e1 100644
--- a/share/html/Install/DatabaseDetails.html
+++ b/share/html/Install/DatabaseDetails.html
@@ -95,7 +95,6 @@
 
 <%init>
 my (@results, @errors);
-my $ConnectionSucceeded;
 
 my @Types = 'DatabaseName';
 

-----------------------------------------------------------------------