[Rt-commit] rt branch, 3.8/perlcritic, updated. rt-3.8.10-182-g491abf3

[Thomas Sibley]

The branch, 3.8/perlcritic has been updated
       via  491abf396d4bc04e0f9ef1ad4344b6c1459dcb8f (commit)
      from  837f4ace7662f95bc592560dfa6fa785c071a28d (commit)

Summary of changes:
 lib/RT/Test.pm |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

- Log -----------------------------------------------------------------
commit 491abf396d4bc04e0f9ef1ad4344b6c1459dcb8f
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Tue Jul 26 10:07:12 2011 -0400

    Silence test warnings by localizing $? to 0 instead of undef
    
    This matches the behaviour of local $?; despite what the perldoc around
    local implies.

diff --git a/lib/RT/Test.pm b/lib/RT/Test.pm
index bab9f61..f619ae4 100644
--- a/lib/RT/Test.pm
+++ b/lib/RT/Test.pm
@@ -1316,7 +1316,7 @@ END {
 
     # we are in END block and should protect our exit code
     # so calls below may call system or kill that clobbers $?
-    local $? = undef;
+    local $? = 0;
 
     RT::Test->stop_server;
 

-----------------------------------------------------------------------