[Rt-commit] rt branch, 4.0/single-quote-email-config-settings, created. rt-4.0.1rc1-133-gc927c32
Alex Vandiver
alexmv at bestpractical.com
Tue Jun 21 17:47:13 EDT 2011
The branch, 4.0/single-quote-email-config-settings has been created
at c927c32cd2ab6bcf1080f3c9ed729828ad2d20d1 (commit)
- Log -----------------------------------------------------------------
commit c927c32cd2ab6bcf1080f3c9ed729828ad2d20d1
Author: Alex Vandiver <alexmv at bestpractical.com>
Date: Tue Jun 21 17:46:42 2011 -0400
Use single quotes for empty strings in email settings
This helps prevent users from blindly putting "foo at bar.com" into the
setting, and being upset when it seems to expand to "foo.com".
diff --git a/etc/RT_Config.pm.in b/etc/RT_Config.pm.in
index c508b7d..97834a4 100755
--- a/etc/RT_Config.pm.in
+++ b/etc/RT_Config.pm.in
@@ -62,9 +62,9 @@ configured as aliases for F<rt-mailgate>.
=cut
-Set($CorrespondAddress, "");
+Set($CorrespondAddress, '');
-Set($CommentAddress, "");
+Set($CommentAddress, '');
=item C<$WebDomain>
@@ -313,7 +313,7 @@ should I<not> be an address that's managed by your RT instance.
=cut
-Set($OwnerEmail, "root");
+Set($OwnerEmail, 'root');
=item C<$LoopsToRTOwner>
@@ -657,7 +657,7 @@ then C<$OwnerEmail> will be used.
=cut
-Set($DashboardAddress, "");
+Set($DashboardAddress, '');
=item C<$DashboardSubject>
-----------------------------------------------------------------------
More information about the Rt-commit
mailing list