[Rt-commit] rtir branch, 2.6/perlcritic, created. 2.6.0-28-gf114362

[Alex Vandiver]

The branch, 2.6/perlcritic has been created
        at  f114362d3239f53f6fecb876f9180eb99b9701eb (commit)

- Log -----------------------------------------------------------------
commit f471ff407b85d04dd9dae7d54bed0c8d52070bfe
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Tue Jun 28 13:34:41 2011 -0400

    Use mutliple-argument form of open()

diff --git a/html/RTIR/Tools/Traceroute.html b/html/RTIR/Tools/Traceroute.html
index d65e79f..11dd70f 100644
--- a/html/RTIR/Tools/Traceroute.html
+++ b/html/RTIR/Tools/Traceroute.html
@@ -60,7 +60,7 @@ unless ( -f $cmd && -x _ ) {
 }
 
 tied(%session)->release_all_locks;
-open my $tr, "$cmd $q|" or Abort("Couldn't run '/usr/sbin/traceroute': $!");
+open(my $tr, "-|", $cmd, $q) or Abort("Couldn't run '/usr/sbin/traceroute': $!");
 </%INIT>
 <%ARGS>
 $q => ''

commit a474fcfb02610b82ab4aa010aeb89050034705d5
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Tue Jun 28 13:37:17 2011 -0400

    Remove totally un-necessary sleep(2) call

diff --git a/html/RTIR/Tools/Traceroute.html b/html/RTIR/Tools/Traceroute.html
index 11dd70f..7d2692f 100644
--- a/html/RTIR/Tools/Traceroute.html
+++ b/html/RTIR/Tools/Traceroute.html
@@ -37,7 +37,6 @@ while (my $content = <$tr>) {
     $m->out( $content );
     $m->out('<br />');
     $m->flush_buffer;
-    sleep(2);
 }
 </%PERL>
 </pre>

commit f114362d3239f53f6fecb876f9180eb99b9701eb
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Thu Jun 30 13:58:30 2011 -0400

    Remove an unnecessary subroutine prototype

diff --git a/etc/add_constituency b/etc/add_constituency
index 196a8c5..56c2410 100644
--- a/etc/add_constituency
+++ b/etc/add_constituency
@@ -60,7 +60,7 @@ RT::Init;
 
 my %opt;
 
-sub debug(@) {
+sub debug {
     return if $opt{'quiet'};
     print @_;
     print "\n" if $_[-1] && $_[-1] !~ /\n$/s;

-----------------------------------------------------------------------