[Rt-commit] rt branch, 3.8/perlcritic, updated. rt-3.8.10-34-gf1189a7

[Alex Vandiver]

The branch, 3.8/perlcritic has been updated
       via  f1189a7ec6e753d7e3fd549ba05693933b90b2a4 (commit)
       via  cf359f5802bfdf198fe52647c08806e2d7c29cc9 (commit)
      from  0fc0ed001b07e3fef8f744f88def9037e65e3afd (commit)

Summary of changes:
 etc/RT_Config.pm.in             |    2 +-
 lib/RT/I18N/cs.pm               |    2 ++
 lib/RT/I18N/ru.pm               |    2 ++
 lib/RT/Interface/Web/Handler.pm |    2 ++
 lib/RT/Interface/Web/Menu.pm    |    3 ++-
 lib/RT/Reminders.pm             |    2 ++
 lib/RT/Report/Tickets/Entry.pm  |    3 +++
 lib/RT/Shredder/Constants.pm    |    2 ++
 sbin/license_tag                |    2 ++
 sbin/merge-rosetta.pl           |    5 +++++
 10 files changed, 23 insertions(+), 2 deletions(-)

- Log -----------------------------------------------------------------
commit cf359f5802bfdf198fe52647c08806e2d7c29cc9
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Thu Jun 30 16:26:21 2011 -0400

    Add strict and warnings to some files missing them

diff --git a/lib/RT/I18N/cs.pm b/lib/RT/I18N/cs.pm
index aaa722e..9ced06c 100755
--- a/lib/RT/I18N/cs.pm
+++ b/lib/RT/I18N/cs.pm
@@ -47,6 +47,8 @@
 # END BPS TAGGED BLOCK }}}
 
 package RT::I18N::cs;
+use strict;
+use warnings;
 
 # # CZECH TRANSLATORS COMMENTS see Locale::Maketext::TPJ13
 # Obecne parametry musi byt docela slozite (v pripade Slavistickych jazyku)
diff --git a/lib/RT/I18N/ru.pm b/lib/RT/I18N/ru.pm
index bf7b587..31f0b53 100755
--- a/lib/RT/I18N/ru.pm
+++ b/lib/RT/I18N/ru.pm
@@ -47,6 +47,8 @@
 # END BPS TAGGED BLOCK }}}
 
 package RT::I18N::ru;
+use strict;
+use warnings;
 
 sub quant {
     my($handle, $num, @forms) = @_;
diff --git a/lib/RT/Interface/Web/Handler.pm b/lib/RT/Interface/Web/Handler.pm
index 0d39208..19f3c46 100644
--- a/lib/RT/Interface/Web/Handler.pm
+++ b/lib/RT/Interface/Web/Handler.pm
@@ -47,6 +47,8 @@
 # END BPS TAGGED BLOCK }}}
 
 package RT::Interface::Web::Handler;
+use strict;
+use warnings;
 
 use CGI qw/-private_tempfiles/;
 use MIME::Entity;
diff --git a/lib/RT/Interface/Web/Menu.pm b/lib/RT/Interface/Web/Menu.pm
index 3b6ce88..8c1e518 100644
--- a/lib/RT/Interface/Web/Menu.pm
+++ b/lib/RT/Interface/Web/Menu.pm
@@ -47,7 +47,8 @@
 # END BPS TAGGED BLOCK }}}
 
 package RT::Interface::Web::Menu;
-
+use strict;
+use warnings;
 
 sub new {
     my $class = shift;
diff --git a/lib/RT/Reminders.pm b/lib/RT/Reminders.pm
index 8d2bdcb..edf3586 100644
--- a/lib/RT/Reminders.pm
+++ b/lib/RT/Reminders.pm
@@ -47,6 +47,8 @@
 # END BPS TAGGED BLOCK }}}
 
 package RT::Reminders;
+use strict;
+use warnings;
 
 use base qw/RT::Base/;
 
diff --git a/lib/RT/Report/Tickets/Entry.pm b/lib/RT/Report/Tickets/Entry.pm
index 158e553..ec97bc2 100644
--- a/lib/RT/Report/Tickets/Entry.pm
+++ b/lib/RT/Report/Tickets/Entry.pm
@@ -47,6 +47,9 @@
 # END BPS TAGGED BLOCK }}}
 
 package RT::Report::Tickets::Entry;
+use strict;
+use warnings;
+
 use base qw/RT::Record/;
 
 # XXX TODO: how the heck do we acl a report?
diff --git a/lib/RT/Shredder/Constants.pm b/lib/RT/Shredder/Constants.pm
index ff00e5a..7a7cc0c 100644
--- a/lib/RT/Shredder/Constants.pm
+++ b/lib/RT/Shredder/Constants.pm
@@ -47,6 +47,8 @@
 # END BPS TAGGED BLOCK }}}
 
 package RT::Shredder::Constants;
+use strict;
+use warnings;
 
 use base qw(Exporter);
 
diff --git a/sbin/license_tag b/sbin/license_tag
index 5bffecb..5720aa9 100755
--- a/sbin/license_tag
+++ b/sbin/license_tag
@@ -1,5 +1,7 @@
 #!/usr/bin/perl
 
+use strict;
+use warnings;
 
 # BEGIN BPS TAGGED BLOCK {{{
 #
diff --git a/sbin/merge-rosetta.pl b/sbin/merge-rosetta.pl
index 06eedf0..eff34f5 100644
--- a/sbin/merge-rosetta.pl
+++ b/sbin/merge-rosetta.pl
@@ -1,4 +1,8 @@
 #!/usr/bin/perl -w
+
+use strict;
+use warnings;
+
 # BEGIN BPS TAGGED BLOCK {{{
 #
 # COPYRIGHT:
@@ -46,4 +50,5 @@
 # those contributions and any derivatives thereof.
 #
 # END BPS TAGGED BLOCK }}}
+
 exec('sbin/rt-message-catalog', 'rosetta', @ARGV);

commit f1189a7ec6e753d7e3fd549ba05693933b90b2a4
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Thu Jun 30 16:26:49 2011 -0400

    We are unable to add "use strict" because of the package vars, but we can at least enable warnings

diff --git a/etc/RT_Config.pm.in b/etc/RT_Config.pm.in
index ea64a2e..9a72acd 100755
--- a/etc/RT_Config.pm.in
+++ b/etc/RT_Config.pm.in
@@ -1,5 +1,5 @@
-
 package RT;
+use warnings;
 
 =head1 NAME
 

-----------------------------------------------------------------------