[Rt-commit] rt branch, 4.0/pod-spell, updated. rt-4.0.0rc6-130-gac7de80

[Shawn Moore]

The branch, 4.0/pod-spell has been updated
       via  ac7de8026f8fbec1cf17f1859e7b20548a3072f1 (commit)
       via  ac8d533b4d9beb7a75efe1826251173e5f55e59a (commit)
      from  0a48ecffe1cecd8155e1fe9cf7e515ae93940c8b (commit)

Summary of changes:
 lib/RT.pm                            |   16 +++++++++-------
 lib/RT/ACE.pm                        |    4 ----
 lib/RT/Group.pm                      |    1 -
 lib/RT/Shredder/CachedGroupMember.pm |    3 ---
 lib/RT/Shredder/GroupMember.pm       |    2 --
 t/99-pod-spelling.t                  |    2 ++
 6 files changed, 11 insertions(+), 17 deletions(-)

- Log -----------------------------------------------------------------
commit ac8d533b4d9beb7a75efe1826251173e5f55e59a
Author: Shawn M Moore <sartak at bestpractical.com>
Date:   Thu Mar 17 17:18:10 2011 -0400

    Spellcheck lib/RT.pm
    
        Except this paragraph which I can't understand:
    
        "This code chacke plugins names or anything else and required when main
        config is loaded to load plugins' configs."

diff --git a/lib/RT.pm b/lib/RT.pm
index 9d51fad..bc5a4e0 100644
--- a/lib/RT.pm
+++ b/lib/RT.pm
@@ -569,8 +569,9 @@ sub UnprivilegedUsers {
 
 =head2 Plugins
 
-Returns a listref of all Plugins currently configured for this RT instance.
-You can define plugins by adding them to the @Plugins list in your RT_SiteConfig
+Returns an array reference of all Plugins currently configured for this RT
+instance. You can define plugins by adding them to the C<@Plugins> list in your
+F<RT_SiteConfig.pm>
 
 =cut
 
@@ -586,7 +587,8 @@ sub Plugins {
 
 =head2 PluginDirs
 
-Takes optional subdir (e.g. po, lib, etc.) and return plugins' dirs that exist.
+Takes an optional subdirectory (e.g. F<po>, F<lib>, etc.) and returns plugins'
+directories that exist.
 
 This code chacke plugins names or anything else and required when main config
 is loaded to load plugins' configs.
@@ -640,7 +642,8 @@ sub InitPluginPaths {
 
 =head2 InitPlugins
 
-Initialze all Plugins found in the RT configuration file, setting up their lib and HTML::Mason component roots.
+Initialize all Plugins found in the RT configuration file, setting up their lib
+and HTML::Mason component roots.
 
 =cut
 
@@ -716,9 +719,8 @@ sub CanonicalizeGeneratedPaths {
 
 =head2 AddJavaScript
 
-helper method to add js files to C<JSFiles> config.
-to add extra css files, you can add the following line
-in the plugin's main file:
+Helper method to add JavaScript files to C<JSFiles> config. To add extra
+JavaScript files, you can add the following line in the plugin's main file:
 
     RT->AddJavaScript( 'foo.js', 'bar.js' ); 
 
diff --git a/t/99-pod-spelling.t b/t/99-pod-spelling.t
index 154b0d4..a737b5d 100644
--- a/t/99-pod-spelling.t
+++ b/t/99-pod-spelling.t
@@ -69,12 +69,14 @@ reblesses
 resultset
 runtime
 startup
+subdirectory
 tuple
 tuples
 unicode
 unix
 username
 workflow
+hostname
 
 # RT JARGON
 ACEs

commit ac7de8026f8fbec1cf17f1859e7b20548a3072f1
Author: Shawn M Moore <sartak at bestpractical.com>
Date:   Thu Mar 17 17:24:34 2011 -0400

    Remove comments referencing rights delegation

diff --git a/lib/RT/ACE.pm b/lib/RT/ACE.pm
index d8a4187..f8677ce 100644
--- a/lib/RT/ACE.pm
+++ b/lib/RT/ACE.pm
@@ -314,8 +314,6 @@ Delete this object. This method should ONLY ever be called from RT::User or RT::
 If this is being called from within a transaction, specify a true value for the parameter InsideTransaction.
 Really, DBIx::SearchBuilder should use and/or fake subtransactions
 
-This routine will also recurse and delete any delegations of this right
-
 =cut
 
 sub Delete {
@@ -325,8 +323,6 @@ sub Delete {
         return ( 0, $self->loc('Right not loaded.') );
     }
 
-    # A user can delete an ACE if the current user has the right to modify it and it's not a delegated ACE
-    # or if it's a delegated ACE and it was delegated by the current user
     unless ($self->CurrentUser->HasRight(Right => 'ModifyACL', Object => $self->Object)) {
         return ( 0, $self->loc('Permission Denied') );
     }
diff --git a/lib/RT/Group.pm b/lib/RT/Group.pm
index 1ee0591..e048f48 100644
--- a/lib/RT/Group.pm
+++ b/lib/RT/Group.pm
@@ -628,7 +628,6 @@ sub Delete {
     # Remove this group from anything it's a member of.
     # Remove all cached members of this group
     # Remove any rights granted to this group
-    # remove any rights delegated by way of this group
 
     return ( $self->SUPER::Delete(@_) );
 }
diff --git a/lib/RT/Shredder/CachedGroupMember.pm b/lib/RT/Shredder/CachedGroupMember.pm
index 0a6f253..f350689 100644
--- a/lib/RT/Shredder/CachedGroupMember.pm
+++ b/lib/RT/Shredder/CachedGroupMember.pm
@@ -75,9 +75,6 @@ sub __DependsOn
     $objs->Limit( FIELD => 'id', OPERATOR => '!=', VALUE => $self->Id );
     push( @$list, $objs );
 
-# principal lost group membership and lost some rights which he could delegate to
-# some body
-
 # XXX: Here is problem cause HasMemberRecursively would return true allways
 # cause we didn't delete anything yet. :(
     # if pricipal is not member anymore(could be via other groups) then proceed
diff --git a/lib/RT/Shredder/GroupMember.pm b/lib/RT/Shredder/GroupMember.pm
index 2710887..d1b79e8 100644
--- a/lib/RT/Shredder/GroupMember.pm
+++ b/lib/RT/Shredder/GroupMember.pm
@@ -75,8 +75,6 @@ sub __DependsOn
     $objs->Limit( FIELD => 'ImmediateParentId', VALUE => $self->GroupId );
     push( @$list, $objs );
 
-    # XXX: right delegations should be cleaned here
-
     $deps->_PushDependencies(
             BaseObject => $self,
             Flags => DEPENDS_ON,

-----------------------------------------------------------------------