[Rt-commit] rt branch, 4.2/dashboard-tables, updated. rt-4.0.0rc6-186-g414eb7f

[Shawn Moore]

The branch, 4.2/dashboard-tables has been updated
       via  414eb7f19a09874e9b6e80e89b2bd631e069714a (commit)
       via  4638945c4cea1ba831bd5efd64f222285c3039c8 (commit)
       via  1f745db7fb68632af72483e5947fb49eb728f709 (commit)
      from  1c4fd3aad9ab35c43cfa68cb6020e372175c46b0 (commit)

Summary of changes:
 lib/RT/Dashboard.pm  |   56 +-------------------------------------------------
 lib/RT/Dashboards.pm |    2 +-
 2 files changed, 2 insertions(+), 56 deletions(-)

- Log -----------------------------------------------------------------
commit 1f745db7fb68632af72483e5947fb49eb728f709
Author: Shawn M Moore <sartak at bestpractical.com>
Date:   Tue Mar 22 14:02:40 2011 -0400

    Typo fix

diff --git a/lib/RT/Dashboards.pm b/lib/RT/Dashboards.pm
index 5037b6f..c5a9729 100644
--- a/lib/RT/Dashboards.pm
+++ b/lib/RT/Dashboards.pm
@@ -82,7 +82,7 @@ sub LimitToObject {
 
     $self->Limit(
         FIELD => 'ObjectType',
-        VALUE => ref($obj);
+        VALUE => ref($obj),
     );
 
     $self->Limit(

commit 4638945c4cea1ba831bd5efd64f222285c3039c8
Author: Shawn M Moore <sartak at bestpractical.com>
Date:   Tue Mar 22 14:10:26 2011 -0400

    Remove some RT::SharedSetting-specific stuff

diff --git a/lib/RT/Dashboard.pm b/lib/RT/Dashboard.pm
index 2135f70..3ea4519 100644
--- a/lib/RT/Dashboard.pm
+++ b/lib/RT/Dashboard.pm
@@ -100,59 +100,6 @@ RT::System::AddRightCategories(
     DeleteOwnDashboard => 'Staff',
 );
 
-=head2 ObjectName
-
-An object of this class is called "dashboard"
-
-=cut
-
-sub ObjectName { "dashboard" }
-
-sub SaveAttribute {
-    my $self   = shift;
-    my $object = shift;
-    my $args   = shift;
-
-    return $object->AddAttribute(
-        'Name'        => 'Dashboard',
-        'Description' => $args->{'Name'},
-        'Content'     => {Panes => $args->{'Panes'}},
-    );
-}
-
-sub UpdateAttribute {
-    my $self = shift;
-    my $args = shift;
-
-    my ($status, $msg) = (1, undef);
-    if (defined $args->{'Panes'}) {
-        ($status, $msg) = $self->{'Attribute'}->SetSubValues(
-            Panes => $args->{'Panes'},
-        );
-    }
-
-    if ($status && $args->{'Name'}) {
-        ($status, $msg) = $self->{'Attribute'}->SetDescription($args->{'Name'})
-            unless $self->Name eq $args->{'Name'};
-    }
-
-    if ($status && $args->{'Privacy'}) {
-        my ($new_obj_type, $new_obj_id) = split /-/, $args->{'Privacy'};
-        my ($obj_type, $obj_id) = split /-/, $self->Privacy;
-
-        my $attr = $self->{'Attribute'};
-        if ($new_obj_type ne $obj_type) {
-            ($status, $msg) = $attr->SetObjectType($new_obj_type);
-        }
-        if ($status && $new_obj_id != $obj_id ) {
-            ($status, $msg) = $attr->SetObjectId($new_obj_id);
-        }
-        $self->{'Privacy'} = $args->{'Privacy'} if $status;
-    }
-
-    return ($status, $msg);
-}
-
 =head2 Panes
 
 Returns a hashref of pane name to portlets

commit 414eb7f19a09874e9b6e80e89b2bd631e069714a
Author: Shawn M Moore <sartak at bestpractical.com>
Date:   Tue Mar 22 14:10:34 2011 -0400

    Pull Panes out from Content

diff --git a/lib/RT/Dashboard.pm b/lib/RT/Dashboard.pm
index 3ea4519..8759f2b 100644
--- a/lib/RT/Dashboard.pm
+++ b/lib/RT/Dashboard.pm
@@ -108,8 +108,7 @@ Returns a hashref of pane name to portlets
 
 sub Panes {
     my $self = shift;
-    return unless ref($self->{'Attribute'}) eq 'RT::Attribute';
-    return $self->{'Attribute'}->SubValue('Panes') || {};
+    return $self->Content->{Panes} || {};
 }
 
 =head2 Portlets

-----------------------------------------------------------------------