[Rt-commit] rt branch, 4.0/label-fields, updated. rt-4.0.0rc7-155-g6cc5fa7

Shawn Moore sartak at bestpractical.com
Thu Mar 24 16:24:48 EDT 2011


The branch, 4.0/label-fields has been updated
       via  6cc5fa7a6ee1766f3da473fbb4bc6be61179bbd7 (commit)
       via  8b585948a071f84e742145ceb8e8818b7efe6667 (commit)
      from  2a98370b28c2f64d39db776289a0afae948c9196 (commit)

Summary of changes:
 share/html/Elements/EditLinks                      |   24 ++++++++++----------
 share/html/Search/Elements/SelectAndOr             |    4 +-
 share/html/Ticket/Elements/AddAttachments          |    4 ++-
 .../Ticket/Graphs/Elements/EditGraphProperties     |   10 +++++---
 4 files changed, 23 insertions(+), 19 deletions(-)

- Log -----------------------------------------------------------------
commit 8b585948a071f84e742145ceb8e8818b7efe6667
Author: Shawn M Moore <sartak at bestpractical.com>
Date:   Thu Mar 24 15:47:37 2011 -0400

    Wrap and/or in a label
    
        I hesitate to use a <label for=""> since this seems a lot more
        likely than other templates to show up on a page a bunch.

diff --git a/share/html/Search/Elements/SelectAndOr b/share/html/Search/Elements/SelectAndOr
index a644a71..60f3896 100644
--- a/share/html/Search/Elements/SelectAndOr
+++ b/share/html/Search/Elements/SelectAndOr
@@ -45,8 +45,8 @@
 %# those contributions and any derivatives thereof.
 %#
 %# END BPS TAGGED BLOCK }}}
-<input type="radio" class="radio" name="<%$Name%>" checked="checked" value="AND" /><&|/l&>AND</&>
-<input type="radio" class="radio" name="<%$Name%>" value="OR" /><&|/l&>OR</&>
+<label><input type="radio" class="radio" name="<%$Name%>" checked="checked" value="AND" /><&|/l&>AND</&></label>
+<label><input type="radio" class="radio" name="<%$Name%>" value="OR" /><&|/l&>OR</&></label>
 
 <%ARGS>
 $Name => "Operator"

commit 6cc5fa7a6ee1766f3da473fbb4bc6be61179bbd7
Author: Shawn M Moore <sartak at bestpractical.com>
Date:   Thu Mar 24 16:24:36 2011 -0400

    Add still more <label>s

diff --git a/share/html/Elements/EditLinks b/share/html/Elements/EditLinks
index 05a9280..a2e6bc6 100755
--- a/share/html/Elements/EditLinks
+++ b/share/html/Elements/EditLinks
@@ -55,8 +55,8 @@
     <td class="labeltop"><& ShowRelationLabel, id => $id, Label => loc('Depends on'), Relation => 'DependsOn' &>:</td>
     <td class="value">
 % while (my $link = $Object->DependsOn->Next) {
-      <input type="checkbox" class="checkbox" name="DeleteLink--<%$link->Type%>-<%$link->Target%>" value="1" />
-        <& ShowLink, URI => $link->TargetURI &><br />
+      <input type="checkbox" class="checkbox" id="DeleteLink--<%$link->Type%>-<%$link->Target%>" name="DeleteLink--<%$link->Type%>-<%$link->Target%>" value="1" />
+      <label for="DeleteLink--<%$link->Type%>-<%$link->Target%>"><& ShowLink, URI => $link->TargetURI &></label><br />
 % }
     </td>
   </tr>
@@ -64,8 +64,8 @@
     <td class="labeltop"><& ShowRelationLabel, id => $id, Label => loc('Depended on by'), Relation => 'DependedOnBy' &>:</td>
     <td class="value">
 % while (my $link = $Object->DependedOnBy->Next) {
-      <input type="checkbox" class="checkbox" name="DeleteLink-<%$link->Base%>-<%$link->Type%>-" value="1" />
-        <& ShowLink, URI => $link->BaseURI &><br />
+      <input type="checkbox" class="checkbox" id="DeleteLink-<%$link->Base%>-<%$link->Type%>-" name="DeleteLink-<%$link->Base%>-<%$link->Type%>-" value="1" />
+      <label for="DeleteLink-<%$link->Base%>-<%$link->Type%>-"><& ShowLink, URI => $link->BaseURI &></label><br />
 % }
     </td>
   </tr>
@@ -73,8 +73,8 @@
     <td class="labeltop"><& ShowRelationLabel, id => $id, Label => loc('Parents'), Relation => 'Parents' &>:</td>
     <td class="value">
 % while (my $link = $Object->MemberOf->Next) {
-      <input type="checkbox" class="checkbox" name="DeleteLink--<%$link->Type%>-<%$link->Target%>" value="1" />
-        <& ShowLink, URI => $link->TargetURI &><br />
+      <input type="checkbox" class="checkbox" id="DeleteLink--<%$link->Type%>-<%$link->Target%>" name="DeleteLink--<%$link->Type%>-<%$link->Target%>" value="1" />
+      <label for="DeleteLink--<%$link->Type%>-<%$link->Target%>"><& ShowLink, URI => $link->TargetURI &></label><br />
 % }
     </td>
   </tr>
@@ -82,8 +82,8 @@
     <td class="labeltop"><& ShowRelationLabel, id => $id, Label => loc('Children'), Relation => 'Children' &>:</td>
     <td class="value">
 % while (my $link = $Object->Members->Next) {
-      <input type="checkbox" class="checkbox" name="DeleteLink-<%$link->Base%>-<%$link->Type%>-" value="1" />
-        <& ShowLink, URI => $link->BaseURI &><br />
+      <input type="checkbox" class="checkbox" id="DeleteLink-<%$link->Base%>-<%$link->Type%>-" name="DeleteLink-<%$link->Base%>-<%$link->Type%>-" value="1" />
+      <label for="DeleteLink-<%$link->Base%>-<%$link->Type%>-"><& ShowLink, URI => $link->BaseURI &></label><br />
 % }
     </td>
   </tr>
@@ -91,8 +91,8 @@
     <td class="labeltop"><& ShowRelationLabel, id => $id, Label => loc('Refers to'), Relation => 'RefersTo' &>:</td>
     <td class="value">
 % while (my $link = $Object->RefersTo->Next) {
-      <input type="checkbox" class="checkbox" name="DeleteLink--<%$link->Type%>-<%$link->Target%>" value="1" />
-        <& ShowLink, URI => $link->TargetURI &><br />
+      <input type="checkbox" class="checkbox" id="DeleteLink--<%$link->Type%>-<%$link->Target%>" name="DeleteLink--<%$link->Type%>-<%$link->Target%>" value="1" />
+      <label for="DeleteLink--<%$link->Type%>-<%$link->Target%>"><& ShowLink, URI => $link->TargetURI &></label><br />
 %}
     </td>
   </tr>
@@ -102,8 +102,8 @@
 % while (my $link = $Object->ReferredToBy->Next) {
 % # Skip reminders
 % next if (UNIVERSAL::isa($link->BaseObj, 'RT::Ticket')  && $link->BaseObj->Type eq 'reminder');
-      <input type="checkbox" class="checkbox" name="DeleteLink-<%$link->Base%>-<%$link->Type%>-" value="1" />
-        <& ShowLink, URI => $link->BaseURI &><br />
+      <input type="checkbox" class="checkbox" id="DeleteLink-<%$link->Base%>-<%$link->Type%>-" name="DeleteLink-<%$link->Base%>-<%$link->Type%>-" value="1" />
+      <label for="DeleteLink-<%$link->Base%>-<%$link->Type%>-"><& ShowLink, URI => $link->BaseURI &></label><br />
 % }
     </td>
   </tr>
diff --git a/share/html/Ticket/Elements/AddAttachments b/share/html/Ticket/Elements/AddAttachments
index ba97a83..d1cc5c1 100644
--- a/share/html/Ticket/Elements/AddAttachments
+++ b/share/html/Ticket/Elements/AddAttachments
@@ -50,7 +50,9 @@
 <td>
 <&|/l&>Check box to delete</&><br />
 % foreach my $attach_name (keys %{$session{'Attachments'}}) {
-<input type="checkbox" class="checkbox" name="DeleteAttach-<%$attach_name%>" value="1" /><%$attach_name%><br />
+<input type="checkbox" class="checkbox" id="DeleteAttach-<%$attach_name%>" name="DeleteAttach-<%$attach_name%>" value="1" />
+<label for="DeleteAttach-<%$attach_name%>"><%$attach_name%></label>
+<br />
 % } # end of foreach
 </td>
 </tr>
diff --git a/share/html/Ticket/Graphs/Elements/EditGraphProperties b/share/html/Ticket/Graphs/Elements/EditGraphProperties
index beb67a2..822df60 100644
--- a/share/html/Ticket/Graphs/Elements/EditGraphProperties
+++ b/share/html/Ticket/Graphs/Elements/EditGraphProperties
@@ -72,7 +72,8 @@
 % foreach my $type ( @link_types ) {
 % my $checked = '';
 % $checked = 'checked="checked"' if grep $type eq $_, @ShowLinks;
-<input type="checkbox" name="ShowLinks" value="<% $type %>" <% $checked |n %> /><% loc($type) %>
+<input type="checkbox" id="ShowLinks" name="ShowLinks" value="<% $type %>" <% $checked |n %> />
+<label for="ShowLinks"><% loc($type) %></label>
 % }
 <br />
 
@@ -98,8 +99,8 @@ while ( my ($group, $list) = (splice @tmp, 0, 2) ) {
 % if ( RT::Link->can('Description' ) ) {
 % my $checked = '';
 % $checked = 'checked="checked"' if $ShowLinkDescriptions;
-<% loc('Show link descriptions') %>:
-<input type="checkbox" name="ShowLinkDescriptions" value="1" <% $checked |n %> />
+<label for="ShowLinkDescriptions"><% loc('Show link descriptions') %>:</label>
+<input type="checkbox" id="ShowLinkDescriptions" name="ShowLinkDescriptions" value="1" <% $checked |n %> />
 <br />
 % }
 
@@ -158,7 +159,8 @@ $class = 'class="hidden"' if $Level != 1 && !@Default;
 % foreach my $prop ( @$list ) {
 % my $checked = '';
 % $checked = 'checked="checked"' if grep $_ eq $prop, @Default;
-<input type="checkbox" class="checkbox" name="Level-<% $Level %>-Properties" value="<% $prop %>" <% $checked |n %> /><% loc($prop) %>
+<input type="checkbox" class="checkbox" id="Level-<% $Level %>-Properties" name="Level-<% $Level %>-Properties" value="<% $prop %>" <% $checked |n %> />
+<label for="Level-<% $Level %>-Properties"><% loc($prop) %></label>
 % }
 </td></tr>
 % }

-----------------------------------------------------------------------


More information about the Rt-commit mailing list