[Rt-commit] rt branch, 4.0/criteria-overflow, created. rt-4.0.0-167-g12db3c6

[Thomas Sibley]

The branch, 4.0/criteria-overflow has been created
        at  12db3c68b646a453cacfbc2dcb7fc224bd888f65 (commit)

- Log -----------------------------------------------------------------
commit 85e8c2fc39e60ae1549940a5f739a729394014d2
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Thu Apr 21 12:22:02 2011 -0400

    URI escape filenames when displaying file/image CFs
    
    This fixes #17173.

diff --git a/share/html/Elements/ShowCustomFieldBinary b/share/html/Elements/ShowCustomFieldBinary
index d08e807..294e27b 100644
--- a/share/html/Elements/ShowCustomFieldBinary
+++ b/share/html/Elements/ShowCustomFieldBinary
@@ -45,7 +45,7 @@
 %# those contributions and any derivatives thereof.
 %#
 %# END BPS TAGGED BLOCK }}}
-<a href="<%RT->Config->Get('WebPath')%>/Download/CustomFieldValue/<% $Object->Id %>/<% $Object->Content %>"><% $Object->Content %></a>
+<a href="<%RT->Config->Get('WebPath')%>/Download/CustomFieldValue/<% $Object->Id %>/<% $Object->Content |u %>"><% $Object->Content %></a>
 <%ARGS>
 $Object => undef
 </%ARGS>
diff --git a/share/html/Elements/ShowCustomFieldImage b/share/html/Elements/ShowCustomFieldImage
index 3d22e5c..71bee62 100644
--- a/share/html/Elements/ShowCustomFieldImage
+++ b/share/html/Elements/ShowCustomFieldImage
@@ -45,7 +45,7 @@
 %# those contributions and any derivatives thereof.
 %#
 %# END BPS TAGGED BLOCK }}}
-%    my $url = RT->Config->Get('WebPath') . "/Download/CustomFieldValue/".$Object->Id.'/'.$Object->Content;
+%    my $url = RT->Config->Get('WebPath') . "/Download/CustomFieldValue/".$Object->Id.'/'.$m->interp->apply_escapes($Object->Content, 'u');
 <a href="<% $url %>"><% $Object->Content %></a>
 <img type="<% $Object->ContentType %>" height="64" src="<% $url %>" align="middle" />
 <%ARGS>

commit 12db3c68b646a453cacfbc2dcb7fc224bd888f65
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Tue May 3 11:08:10 2011 -0400

    Allow options in search criteria to properly overflow the select
    
    The * selector setting a width was far too broad.  Chrome still
    overflowed the options, but Firefox didn't.

diff --git a/share/html/NoAuth/css/aileron/ticket-search.css b/share/html/NoAuth/css/aileron/ticket-search.css
index 082a23b..e524926 100644
--- a/share/html/NoAuth/css/aileron/ticket-search.css
+++ b/share/html/NoAuth/css/aileron/ticket-search.css
@@ -63,11 +63,8 @@
     width: 11em;
 }
 
-#pick-criteria td.label * {
- width: 8.5em;
-}
-
 #pick-criteria td.label select {
+  width: 8.5em;
   text-align: right;
 }
 
diff --git a/share/html/NoAuth/css/ballard/ticket-search.css b/share/html/NoAuth/css/ballard/ticket-search.css
index bff7e9e..c4712f5 100644
--- a/share/html/NoAuth/css/ballard/ticket-search.css
+++ b/share/html/NoAuth/css/ballard/ticket-search.css
@@ -63,11 +63,8 @@
     width: 11em;
 }
 
-#pick-criteria td.label * {
- width: 8.5em;
-}
-
 #pick-criteria td.label select {
+  width: 8.5em;
   text-align: right;
 }
 
diff --git a/share/html/NoAuth/css/web2/ticket-search.css b/share/html/NoAuth/css/web2/ticket-search.css
index 48b805c..e7f7010 100644
--- a/share/html/NoAuth/css/web2/ticket-search.css
+++ b/share/html/NoAuth/css/web2/ticket-search.css
@@ -63,11 +63,8 @@
     width: 11em;
 }
 
-#pick-criteria td.label * {
- width: 8.5em;
-}
-
 #pick-criteria td.label select {
+  width: 8.5em;
   text-align: right;
 }
 

-----------------------------------------------------------------------