[Rt-commit] rt branch, 4.0/custom-logo-in-mobile, created. rt-4.0.0-183-g38eee08

Thomas Sibley trs at bestpractical.com
Thu May 5 10:53:16 EDT 2011


The branch, 4.0/custom-logo-in-mobile has been created
        at  38eee08a1da52a18a254bb1d96e15f581bac6bbe (commit)

- Log -----------------------------------------------------------------
commit c9f4d7ae876c7b52986244e9149f553f6657989b
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Thu May 5 10:46:28 2011 -0400

    Show the custom logo at the top of the mobile UI
    
    Switch to always showing the BPS logo at the bottom (using a CSS
    background), like on normal RT pages.

diff --git a/share/html/m/_elements/footer b/share/html/m/_elements/footer
index ea5db9d..44b7253 100644
--- a/share/html/m/_elements/footer
+++ b/share/html/m/_elements/footer
@@ -1,5 +1,4 @@
   <div id="bpscredits">
-    <& /Elements/Logo, ShowName => 0 &>
     <div id="copyright">
 <&|/l,     '', '', '2011', '<a href="http://www.bestpractical.com?rt='.$RT::VERSION.'">Best Practical Solutions, LLC</a>', &>[_1] RT [_2] Copyright 1996-[_3] [_4].</&>
 </div>
diff --git a/share/html/m/_elements/header b/share/html/m/_elements/header
index 9d72632..9843a33 100644
--- a/share/html/m/_elements/header
+++ b/share/html/m/_elements/header
@@ -67,6 +67,7 @@ $r->headers_out->{'Cache-control'} = 'no-cache';
 <a href="<%RT->Config->Get('WebPath')%>/m/"><&|/l&>Homepage</&></a>
 </div>
 % }
+<& /Elements/Logo, ShowName => 0 &>
 % if ($title) {
 <h1><%$title%></h1>
 % }
diff --git a/share/html/m/_elements/raw_style b/share/html/m/_elements/raw_style
index a645cca..39e0907 100644
--- a/share/html/m/_elements/raw_style
+++ b/share/html/m/_elements/raw_style
@@ -352,12 +352,6 @@ div#login-box input[type=text], div#login-box input[type=password] {
     width: 100%;
 }
 
-#bpscredits img {
-    padding-bottom: 1em;
-}
-
-
-
 #bpscredits {
     float: right;
     text-align: right;
@@ -366,6 +360,11 @@ div#login-box input[type=text], div#login-box input[type=password] {
     padding: 1em;
 }
 
+#bpscredits #copyright {
+    padding-top: 4em;
+    background: white url(<%RT->Config->Get('WebPath')%>/NoAuth/images/bpslogo.png) no-repeat top right;
+}
+
 
 :focus {
     background-color: #ffc;
@@ -408,6 +407,20 @@ form {
     color: #000;
 }
 
+#logo {
+    position: absolute;
+    right: 5em;
+    top: 0;
+    height: 1.9em;
+}
+
+#logo a img {
+    border: 0;
+    height: 100% !important;
+    width: auto !important;
+    float: right;
+}
+
 div.txn-content {
     
     font-size:0.8em;

commit 4da931cd14b23cca4398f3585c9299f86f45f324
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Thu May 5 10:48:08 2011 -0400

    Make sure every mobile page has a title so the logo doesn't look weird

diff --git a/share/html/m/_elements/header b/share/html/m/_elements/header
index 9843a33..2b06d39 100644
--- a/share/html/m/_elements/header
+++ b/share/html/m/_elements/header
@@ -46,7 +46,7 @@
 %#
 %# END BPS TAGGED BLOCK }}}
 <%args>
-$title => undef
+$title => loc('RT for [_1]', RT->Config->Get('rtname'))
 $show_home_button => 1
 </%args>
 <%init>

commit 3fb71df1c2535ab786dba61893051b6d9ce8cbc9
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Thu May 5 10:48:52 2011 -0400

    Give more useful titles to the ticket pages
    
    This is especially useful for tickets without subjects.

diff --git a/share/html/m/ticket/history b/share/html/m/ticket/history
index a1b9954..9535bbf 100644
--- a/share/html/m/ticket/history
+++ b/share/html/m/ticket/history
@@ -53,7 +53,7 @@ my $t = RT::Ticket->new($session{CurrentUser});
 $t->Load($id);
 my $history = $t->Transactions()->ItemsArrayRef;
 </%init>
-<&| /m/_elements/wrapper, title => $t->Subject &>
+<&| /m/_elements/wrapper, title => loc("#[_1]: [_2]", $t->Id, $t->Subject || '') &>
 <div class="history">
 <& /m/_elements/ticket_menu, ticket => $t &>
 <&|/Widgets/TitleBox &>
diff --git a/share/html/m/ticket/show b/share/html/m/ticket/show
index 8037623..afea61e 100644
--- a/share/html/m/ticket/show
+++ b/share/html/m/ticket/show
@@ -202,7 +202,7 @@ my $print_value = sub {
 };
 
 </%init>
-<&| /m/_elements/wrapper, title => $Ticket->Subject &>
+<&| /m/_elements/wrapper, title => loc("#[_1]: [_2]", $Ticket->Id, $Ticket->Subject || '') &>
 <div id="ticket-show">
 <& /m/_elements/ticket_menu, ticket => $Ticket &>
 

commit 38eee08a1da52a18a254bb1d96e15f581bac6bbe
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Thu May 5 10:51:23 2011 -0400

    Firefox's default UA styles include a margin for h1s
    
    The margin spaces the title weirdly, so force it to 0.

diff --git a/share/html/m/_elements/raw_style b/share/html/m/_elements/raw_style
index 39e0907..fdbda09 100644
--- a/share/html/m/_elements/raw_style
+++ b/share/html/m/_elements/raw_style
@@ -57,7 +57,7 @@ h1 {
     padding-left: 0.2em;
     display: block; 
     background-color: #fff;
-
+    margin: 0;
 }
 
 div.buttons {

-----------------------------------------------------------------------


More information about the Rt-commit mailing list