[Rt-commit] rt annotated tag, rt-4.0.1rc1, created. rt-4.0.1rc1
Kevin Falcone
falcone at bestpractical.com
Mon May 23 13:23:24 EDT 2011
The annotated tag, rt-4.0.1rc1 has been created
at fe1a00a3a571b5e1a727500f78fe3e2d9cc1599c (tag)
tagging 2fcea5d4f711b616068f0359b6f6471fb913d8c2 (commit)
replaces rt-4.0.0
tagged by Kevin Falcone
on Mon May 23 11:06:55 2011 -0400
- Log -----------------------------------------------------------------
release 4.0.1rc1
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (Darwin)
iEYEABECAAYFAk3aeA8ACgkQ0+gKWp5CJQpRzwCg4JyehAyOklfvMiPtvQwaJPwu
UJ8AoKr2EkWdWiQU05uOijBZyt/pkMEg
=9H8q
-----END PGP SIGNATURE-----
Alex Vandiver (157):
For MySQL, stop dropping privileges when we grant our own ACLs
Escape database names passed to mysql's GRANT, for databases containing _ or %
Move to a SHA-256 based password authentication scheme
Provide a tool to upgrade weak hashes to the new 40-char SHA-256 form
Ignore the new generated file
Merge branch 'protect_mod_perl_stdout' into 3.8-trunk
Ensure that we remove the trailing newline from base64
Always return from the 40-char case, so we don't keep changing the password
Add tests for the various password forms, and automatic upgrading
Abort early under taint mode, and explain how to fix it
Merge commit 'rt-3.8.9' into 3.8-trunk
Give Apache testing the same disconnect/reconnect across the fork treatment
Remove references to "Force" argument to DropDatabase, removed back in 141625a
Only CREATE DATABASE in postgres once
Remove an incorrect comment
Ensure that FlushCache is called on every disconnect
Ensure that the system attribute cache, which holds a DB handle, is cleared on every disconnect
Don't bail early from __disconnect_rt, to ensure that we clear all handles
Simplify bootstrap_db() logic; this also reduces the number of reconnects
Use the RT::Test methods to handle forced disconnection and reconnection
Move reconnect for plugins to only fire if there are plugins enabled
Indent and reword a minor comment
Allow setting apache module path even if apxs is not installed
Bail unless module path is set correctly
Show Apache error log if it fails to start, for debugging
Use skip_all instead of wrapping the entire file in a SKIP block
Whether a ticket ->can($field) depends if the method has been called already
Update test counts to reflect better method reflection
Ensure that a server is running at the end of the test file if not under plack
Always push the decided-upon handler into RT_TEST_WEB_HANDLER, to skip defined checks elsewhere
Always push the decided-upon apache variant into RT_TEST_WEB_HANDLER
Refactor apache_*_server_options into a simple data structure
Remove a possible race condition with an existant but not-yet-written-to apache PID file
Better document why we check caller() on ->Set during tests
Correctly wait until apache children have exited
Fix two test counts that c3f6b26 missed
Give Apache the same 15s to start up that standalone servers get
Unfortunately, caac0b1 runs too late to be able to use for skip_all
The inline test server persists squished data across restarts; clear it
909fce0 causes warnings in stop_server; short-circuit around processes which never started servers
Merge branch '4.0/disable-iframe-embedding' into 4.0-trunk
Merge branch '3.8-trunk' into 4.0-trunk
Merge branch '4.0.0-releng' into 4.0-trunk
Merge branch '4.0/database-init-in-tests' into 4.0-trunk
Merge branch '4.0/plugin-database-init' into 4.0-trunk
Merge branch '4.0/sanity-check-url-config' into 4.0-trunk
Merge branch '4.0/dont-squelch-one-time-recipients' into 4.0-trunk
Initial cut at a hacking doc
Ensure the footer is localized correctly
Merge branch '4.0/stop-hardcoding-perl-really' into 4.0-trunk
Merge branch '4.0/validate-dashboard-subscriber' into 4.0-trunk
Merge branch '4.0/clean-interface-cli' into 4.0-trunk
Merge branch '4.0.0-releng' into 4.0-trunk
Merge branch '4.0/mobile-searches' into 4.0-trunk
Merge branch '4.0/fix-nested-checkbox-labels' into 4.0-trunk
Merge branch '4.0/sort-po-comments' into 4.0-trunk
Merge branch '4.0/remove-duplicate-license' into 4.0-trunk
Merge branch '4.0/remove-extraneous-parens' into 4.0-trunk
Merge branch '4.0/test-logout-refresh' into 4.0-trunk
Merge branch '4.0/uri-escape-cf-filenames' into 4.0-trunk
Merge branch '4.0/subclassing-links-method' into 4.0-trunk
Pull default DBA from autoconf
Add --dry-run option, which is already respected in the code
Show help if options fail to parse
Group questions, then schema changes, then configuration suggestion
Wording and spacing fixes
Update index setup POD
Update indexer POD
Expand the configuration description of %FullTextSearch
Actually set the table and columns like users will when testing
Don't do an extra join if our index is on the Attachments table (like we default to)
Actually use the tsvector column and index that we added
lc(...) will always be ne 'Attachments'; remove the unnecessary and incorrect lc
The configuration key is 'Table', not 'table'; join to an existant table
The content type field is ContentType, not content_type; attachments_html gets it right, however
RT::Attachments->JoinTransactions finds transactions _on_ attachments, not vice versa
The localization sub _ was not imported into the script
Accept the --debug flag which is respected later in the code
Remove some debugging output
Rename attachment collection to be a little more grammatical
We only need to fetch the one last indexed row
Since we will immediately limit on fields of these tables, they need not be left
Work around RT::Tickets->Limit not actually doing limiting
Typo fix; without this, external CFs with NOT LIKE are runtime errors
Typo fix
Pg and mysql operate on their index from the config, not the given column
Needing to handle negative searches is for all databases, not just Pg
Disallow configuring the query column in the Sphinx table
Catch common FTS configuration errors and disable it
Sphinx only works with the "=" operator, not the "LIKE" operator
Configure the number of attachment results to return from Sphinx
Escape ;-as-special-delimiter in Sphinx searches
Note possible optimization which would skip Attachment and Transaction joins
Don't die with "Illegal mix of collations" when searching for unicode
Check that the Postgres version supports full-text searching
Always insert schemas as dba
Be consistent with Oracle and drop the table/column if it exists already
Respect dryrun in more places
Minor formatting cleanup
Move the DontSearchBinaryAttachments config to a flag on index create
Add a --all flag to iterate and index all new txns
Make direct sql via `indexer` the approved way of updating the Sphinx index
Remove unreachable "verbose" code
Centralize full-text searching documentation into one place
Revert "Since we will immediately limit on fields of these tables, they need not be left"
Fix tests, and test all three possibilities of (1||0), (0||1), (1||1)
Allow command-line options to override for prompts
Don't conflict with an existing searchd on the default port
searchd does not pick up the new indexes immediately; sleep a second in the test
Ensure that --index-type gets the case forced correctly
Merge branch '4.0/configureless-install-fixes' into 4.0-trunk
Merge branch '4.0/aftermessagebox-callback' into 4.0-trunk
Test multiple requestors
Merge branch '4.0/cli-list-array-fix' into 4.0-trunk
Merge branch '4.0/consistent-result-msg-quotes' into 4.0-trunk
Merge branch '4.0/mysql-fts' into 4.0/fulltext-search
Update the package variable, rather than making a new lexical
Merge branch '4.0/ipv6-unspecified-address-fix' into 4.0-trunk
Merge branch '4.0/hide-simple-fulltext' into 4.0-trunk
Merge branch '4.0/licensing-fixes' into 4.0-trunk
Merge branch '4.0/set-undefined-email-fix' into 4.0-trunk
Merge branch '4.0/spurious-user-change-results' into 4.0-trunk
We can still use Test::Warn for this case, albeit with a different check
Note why we still write our own __WARN__ handler in this case
Merge branch '4.0/test-warnings' into 4.0-trunk
Merge branch '4.0/third-party-source' into 4.0-trunk
Merge branch '4.0/gpg-lang-fix' into 4.0-trunk
Note unicode limitations of full-text searching solutions
Use RT->Config->Set to adjust mason root, so it gets written to file and Apache tests see it
Trivial typo fix
Remove an unused component
Merge branch '4.0/correct-message-ids' into 4.0-trunk
Merge branch '4.0/self-service-title-fix' into 4.0-trunk
Minor rewording fix
During database maintenance, output warnings to STDERR
Merge branch '4.0/forward-result-msg-tense' into 4.0-trunk
Make attribute ordering consistent
Merge branch '4.0/upgrade-syntax-fixes' into 4.0-trunk
Merge branch '4.0/upgrading-basedon' into 4.0-trunk
Merge branch '4.0/articles-upgrade-script' into 4.0-trunk
Remove ->Resolve from test code, though it is not run
Remove unused code which uses nonexistant ->Resolve method
Refactor "next open status" into a method on the ticket
->Open stopped working when lifecycles landed; replace with ->FirstActiveStatus
Swap the name of the framebusting option to have fewer double-negatives in the code
Fix minor incorrect comment wrapping
Merge branch '4.0/autoload-fixes' into 4.0-trunk
Merge branch '4.0/remove-quoted-null' into 4.0-trunk
Merge branch '4.0/admin-links-in-modify-people-fix' into 4.0-trunk
Replace 3384147 with a less error-prone explicit loop
Fix test count 4.0/autoload-fixes test, adjusting because of b65f769
Similar fix to adabc19 git 4.0/admin-links-in-modify-people-fix
Fix comment, and remove irrelevant sessions check
Merge branch '4.0/article-table-acls' into 4.0-trunk
Merge branch '4.0/delete-private-groups-and-acls-again' into 4.0-trunk
Merge branch '4.0/overdue-fix' into 4.0-trunk
Make clear when we may return undef
Emmanuel Lacour (2):
Doc typo
Add a new callback "AfterMessageBox" in Ticket/Update.html
Jesse Vincent (9):
Small warnings avoidance for tests
close($fh) or die $!
UNIVERSAL::can now used as a method
Use a temporary variable to avoid a perlcritic complaint about
Remove a <> that perlcritic complains about
Work around a complaint by critic that $1 was used outside a conditional
use STDIN instead of <> to make critic happier, although our usage was
Remove a "return sort" to make shredder happy
update license-tag to not insert lines with trailing spaces
Kevin Falcone (50):
Fix incorrect update message
regex fix to actually match
Load the module before we use it
Sync from launchpad
Merge branch '3.8-trunk' into 3.8.9-releng
Log an error, but don't die when there are invalid Scrips
Log an error, but don't die when there are invalid Scrips
Load up safe_run_child before using it
Load up safe_run_child before using it
a few quick cleanups noticed while I was working on the 4.0 readme
Be more forceful about usage of this script
try to convince people to use this
bump version number for 3.8.9rc1
Spelling fixes
Merge branch '3.8/salted-passwords' into 3.8-trunk
Merge branch '3.8-trunk' into 3.8.9-releng
Bump version for 3.8.9rc2
Improved logged message about what the upgrade is doing to Approvals templates
Improved logged message about what the upgrade is doing to Approvals templates
Remove dummy code with wrong parentheses
Merge branch '4.0/fail-taint-mode-early' into 4.0-trunk
Push year to 2011 and also tag scripts in etc/upgrade
send jesse a little less spam
Rerun license tagger
bump version for 3.8.9
Force configure to build the shipped scripts with #!/usr/bin/perl
Please stop hardcoding paths to perl
more hardcoding
Merge branch '4.0.0-releng' into 4.0-trunk
Older versions of RT didn't always set a SearchType
Showing () when there is no Queue description has bothered me forever
Revert "Oracle needs TO_NUMBER to store clob in number column"
Move BasedOn from Attributes to CustomFields.BasedOn
Fix a syntax error so this upgrade script runs
Check that we actually found FM_ tables before doing anything about it
Make it clearer that upgrading into /opt/rt3 is a terrible idea
Talk about upgrading your RT_SiteConfig.pm
Merge branch '4.0/i18n-footer' into 4.0-trunk
Remove DontSearchFileAttachments which is oracle only and create time
Clear a warning about undef in lc on 5.12
Minor doc tweaks
RT::Test::create_ticket(s) had a silent requirement on Queue id
Merge branch '4.0/fulltext-search' into 4.0-trunk
Merge branch '4.0/validate-systeminternal-uniqueness' into 4.0-trunk
Merge branch '4.0/fix-overlay-imports' into 4.0-trunk
Merge branch '4.0/error-ignored-in-upgrade-fix' into 4.0-trunk
Add a 4.0.1 upgrade step to clean up ACLs because 3.9.2 had an error in 4.0.0
Grant rights when the new articles tables are created
Merge branch '4.0/translation-updates' into 4.0-trunk
Merge branch '4.0/hardcoded-status-setters' into 4.0-trunk
Mikal Kolbein Gule (1):
Fix RT::Shredder::Plugin->List to correctly return paths
Ruslan Zakirov (34):
usually sendmail doesn't print anything to stdout
protect FD #1 under mod_perl 2
return back accidentally reverted change
make it possible to override user/pass in ::Handle->Connect
don't connect using system DSN when we don't need it
__reconnect_rt and __disconnect_rt functions
use reconnect and disconnect functions
Ensure that database handles are not left open across calls to fork()
extract create and drop database private helpers
disconnect and clean every possible handle for sure
bootstrap DB if we're testing a plugin that doesn't require any plugins
create plugins element in %args out of testing and requires
put plugins into @Plugins when bootstraping config
split bootstrap_plugins into *_paths and *_db functions
refactor bootstrap plugin_db
reorder how we bootstrap plugins
minor, use less reconnections
use `eq` op instead of regexp
No squelch mode and no NotifyActor affect for One-time recipients
minor
test one time recipients vs. NotifyActor and Squelching
mysql 5.1 has no 'have_sphinx' variable
Sphinx restricts id to unisgned int, newer versions throw error
host/port are not generic methods, authority is
get rid of 3.999-ish calls and DB schema
cleanup sphinx.conf we output
we use Column everywhere (config, script and docs)
use local variable we prepared instead of original value
we also support indexed search on mysql
move CheckSphinxSE method into RT::Handle
RT::Test->temp_directory - returns tmp dir for this test file
test indexed FTS on mysql
test FTS condition (no matches) ORed with subject
no more Column option, but MaxMatches should be defined
Shawn M Moore (93):
SuppressAutoOpenOnUpdate
Warnings and tests for broken WebPath settings
Catch Set($WebPath, '/') as a special case
Validate WebDomain
Validate WebPort
Validate WebBaseURL
Fix WebBaseURL tests
More extensive nested-directory path testing
A few WebBaseURL test tweaks
Validate WebURL
Lock down scheme to http or https
Simplify the 0 and 1 warning test cases
Ensure WebDomain doesn't contain a port
Clean up the RT::System attribute cache every request
Add a hook for validating Web* config against %ENV once per server process
Complain when $SERVER_PORT != WebPort
Complain about WebDomain too
Complain about a bad WebPath
No nee to specify "from a web request"
Fix log message to use the right variable
PSGI spec says prefer HTTP_HOST over SERVER_NAME
"making the error message suggest a direction to fix might be good"
We don't use $host in this branch
Cope with rt-server --port by putting rt.port into %ENV
Clean up and simplify rt-server's --port configuration
Call the %ENV key rt.explicit_port instead of rt.port
Use new PostLoadValidate to ensure what you loaded is actually a dashboard
Unify dashboard load failure Abort calls
Doc thinko fix
Use $Dashboard over $DashboardObj for consistency
->Name is the dashboard name, ->{'Attribute'}->Name is what I wanna look at
Remove redundant and wrongish test code
Test that bad IDs propagate into actual errors
Merge branch '4.0/validate-dashboard-args' into 4.0-trunk
Respect PERL_PREFER_CPAN_CLIENT in fixdeps
Merge branch '4.0/better-fixdeps-command' into 4.0-trunk
Validate email addresses that the user types into Recipient. #13684
Clean up some really old cruft from RT::Interface::CLI
Give RT::Interface::REST a similar de-cruft
Sort po "variables" so they're stable across runs and developers
Merge branch '4.0/message-catalog-all-rosetta-files' into 4.0-trunk
Validate uniqueness of system internal groups
Fix a checkbox list CF nested label bug
Parenthesize our "for qw()"s
Fix more uses of "for my $type qw()"
Test for #16913: "the current value-is-already That" on language change
Actually forgot the test file, doh
Todo the "the current value-is-already That" because oh god the loc_fuzzy
Don't list Lang twice in @fields
Replace some uses of $SIG{__WARN__} with Test::Warn
Use Test::Warn in t/api/template-simple.t too
Improve tickets_overlay_sql.t's style
use Test::Warn for most of t/mail/crypt-gnupg.t
Use methods instead of $RT::System and $RT::SystemUser
Use method calls to avoid once warnings
Clone mech during get_warnings to avoid disrupting mech state
Remove some unhappy hoops from redirect-after-login.t
Pass $m so its destroy runs before global destruction
Make sure we don't generate warnings from walking the menu
/Admin/Global/Template.html takes a Template arg not id
Only update BasedOn if it's different
Only show the you can search fulltext if FullText is on
Clear @tickets at the end of the script
Don't put the content we're searching for in test ticket subjects
Tests for Pg fulltext word stemming (searching for "books" finds "book")
Tests to ensure we can return no tickets :)
Note that StatementLog also gives you the SQL Queries page
Fix clean to call clean_mysql correctly
Deprecate @ExtraSecurity
Rework @ExtraSecurity into $DisableFramebusting
Fix the list POD formatting of RT_Config
Only warn about fulltext speed if it isn't backed by a fts index
Remove duplicate "for any word"
Don't know how I reverted this change
Merge branch '4.0/remove-global-tablesorter' into 4.0-trunk
Merge branch '4.0/custom-logo-in-mobile' into 4.0-trunk
safe_run_child sets both $LANG and $LC_ALL to C for us
No need to actually list @ExtraSecurity as deprecated
Merge branch '4.0/mobile-appearance' into 4.0-trunk
Merge branch '4.0-trunk' into 4.0/apache2-fixes
Fix t/web/walk.t a la c3f6b266 because of b65f7690
Apache rejects busting up above / for us so skip the warning tests
Merge branch '4.0/admin-groups-goto' into 4.0-trunk
TicketSQL has support for IS (NOT) NULL nowadays
Tests for #17421, articles in links that don't show names
Whether a ticket ->can($field) depends if the method has been called already
Use RT->Config->Set to adjust mason root
Merge branch '4.0/apache2-fixes' into 4.0-trunk
Rerun extract-message-catalog to update po metadata
po files where only import metadata changed
Many translation string fixes
Real translation updates
A few more translation syntax fixes
Thomas Sibley (67):
Make sure preferences widgets clear the ones before them
Revert "Reduce whitespace on bottom of boxes by hidding the hr..."
Make clearing <hr>s less space-hungry
Make sure to escape the entire CF name
Rearrange callbacks to provide a means for sending the user to a URL on Logout
Add a javascript framekiller to all pages
Add an X-Frame-Options: DENY header to all responses
Add an @ExtraSecurity config option to control clickjacking countermeasures
Add basic tests for the presence of clickjacking countermeasures
Ensure that RT->Config->ExtraSecurity always returns a scalar
Ensure that ->Links uses the subclasses' ->_Links
Test that the meta-refresh on logout is set correctly
Test that our callback for modifying the logout refresh works
Don't show a trailing colon unless we have a queue
Remove an old license block that's below the current one
URI escape filenames when displaying file/image CFs
Ensure we try to load RT::Interface::Web_(Overlay|Local|Vendor).pm
Don't shove stuff into $_ which might get used later and cause read-only warnings
Our default snapshot setup of using install-sh only works if . is in $PATH
Merge branch '4.0/menu-test' into 4.0-trunk
Allow options in search criteria to properly overflow the select
Merge branch '4.0/forbid-autocomplete-messagebox' into 4.0-trunk
Merge branch '4.0/criteria-overflow' into 4.0-trunk
Remove a pointer to an unmaintained resource
Merge branch '4.0/topactions-form-css-fix' into 4.0-trunk
Show the custom logo at the top of the mobile UI
Make sure every mobile page has a title so the logo doesn't look weird
Give more useful titles to the ticket pages
Firefox's default UA styles include a margin for h1s
Allow input fields to fill up the entire width
Move the custom logo to the bottom to accomodate small screens
Add a "Go to group" autocompleter for Admin Groups
Use the LIKE operator for the "Go to user" form
Move devel/* to devel/tools/ in preparation for other devel contents
Add the third-party source for PIE.htc
Remove our license block from farbtastic
Sources for ckeditor 3.4.1
Source for jQuery 1.4.2
Source for our included jQuery UI components
Move the jQuery tablesorter plugin to the only place we use it
Update jQuery tablesorter and include the appropriate source
Ignore third-party sources when exporting
Build and sign the third-party source tarball during make snapshot
Always show a result message when changing a CF's BasedOn
Consistently quote the old value and new value in the result message
Actually interpolate correctly
Test using a test-specific extra JS file so we can keep the default @JSFiles
Test some of our default JS content as well
Merge branch '4.0/ie7js-cleanup' into 4.0-trunk
Merge branch '4.0/cf-spurious-update' into 4.0-trunk
Add Topics back to the global configuration menu
Encourage branching from the discovery point of the bug
Remove an ambiguous pronoun
Note the need to configure RT and use make test targets instead of prove
Don't force a branch rename in case the reader uses a generic name twice
All branches should be named this way
Make sure they get test deps by using --with-devel-mode
Merge branch '4.0/hacking-docs' into 4.0-trunk
Merge branch '4.0/objecttype-limit' into 4.0-trunk
Don't test for another buggy result message that's fixed on trunk
Merge branch '4.0/default-render-type-fix' into 4.0-trunk
Don't be misleading in our debug messages
Merge branch '4.0/rename-extrasecurity' into 4.0-trunk
Fix tense in our forward result message
Test our Message-ID generation when creating and updating tickets via the web
Avoid two different Message-IDs on update transactions via the web
Remove the default Message-ID if we're making an entity for a file upload
Václav OvsÃk (1):
Use list context so we find all files in rosetta
sunnavy (28):
be consistent with 4.0
be consistent with 4.0
main_content maybe empty
we don't like 2 args open any more
add parens for open() call to avoid confusion; also with left 2-arg => 3-arg change
noautocomplete for messagebox, see #16746
rewrite walk.t to find all the menu links smartly
shredder menu link fix
RT::User->SetEmailAddress(undef) means to empty it
make *all* the forms in topactions float, see also #17282
"::" is valid ipv6, we should allow that
the value can be arrayref too if the format is "s"
cli test of "ls -s -f Requestors", we got ARRAY(0x...) output before
use ', ' as seperator consistently
we don't use IE7.js actually
no IE7.js any more, use util.js to test instead
we want the render type string, not just if defined
cf render type test
test the buggy message of rendertype when a non-select cf chagned to select cf, see also #17326
don't even show modify links if user lacks the rights
admin links test in /Ticket/ModifyPeople.html, see #16907
trans %ARGS to /Elements/Header, especially because it contains title info
start selfservice test, initially for the title fix
overdue html fix
return error once we encounter a problem in upgrade
paren directly after 'alter table ... add column' is disallowed
paren directly after 'alter table ... add column' is disallowed
we definitely want to show user/group info, just without admin links if no proper rights
-----------------------------------------------------------------------
More information about the Rt-commit
mailing list