[Rt-commit] rt branch, 4.0/loc-cleanups, updated. rt-4.0.1rc1-4-g45fc17a

Shawn Moore sartak at bestpractical.com
Mon May 23 16:54:05 EDT 2011


The branch, 4.0/loc-cleanups has been updated
       via  45fc17aa683e8416aeb17fd0af34b38e6a6bd05b (commit)
      from  323087c3a637d406ee3740093b7f9389b9c92e1c (commit)

Summary of changes:
 share/html/Elements/CreateTicket |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

- Log -----------------------------------------------------------------
commit 45fc17aa683e8416aeb17fd0af34b38e6a6bd05b
Author: Shawn M Moore <sartak at bestpractical.com>
Date:   Mon May 23 16:49:51 2011 -0400

    Refactor the create-ticket loc string to have less HTML
    
        The old version required translators to keep our HTML exactly
        correct, which is prone to error and looks gross.

diff --git a/share/html/Elements/CreateTicket b/share/html/Elements/CreateTicket
index 221c4cb..e6a695c 100755
--- a/share/html/Elements/CreateTicket
+++ b/share/html/Elements/CreateTicket
@@ -48,7 +48,10 @@
 <form action="<% RT->Config->Get('WebPath') %><% $SendTo %>" name="CreateTicketInQueue" id="CreateTicketInQueue" \
 % $m->callback(CallbackName => 'InFormElement');
 >
-<&|/l, $m->scomp('/Elements/SelectNewTicketQueue', OnChange => 'document.CreateTicketInQueue.submit()', SendTo => $SendTo ) &><input type="submit" class="button" value="New ticket in" />&nbsp;[_1]</&>
+% my $button_start = '<input type="submit" class="button" value="';
+% my $button_end = '" />';
+% my $queue_selector = $m->scomp('/Elements/SelectNewTicketQueue', OnChange => 'document.CreateTicketInQueue.submit()', SendTo => $SendTo );
+<&|/l, $button_start, $button_end, $queue_selector &>[_1]New ticket in[_2]&nbsp;[_3]</&>
 % $m->callback(CallbackName => 'BeforeFormEnd');
 </form>
 <%ARGS>

-----------------------------------------------------------------------


More information about the Rt-commit mailing list