[Rt-commit] rt branch, 4.0/upgrade-articles-acl-workaround, updated. rt-4.0.1rc1-5-g4d2a816

Emannuel Lacour elacour at bestpractical.com
Thu May 26 03:48:49 EDT 2011


The branch, 4.0/upgrade-articles-acl-workaround has been updated
       via  4d2a816cfa1543b17b9661daaf6b7f3b2fd4f13e (commit)
      from  9cce23cb5b9bcc9464fbc94daa701bc39a1301c4 (commit)

Summary of changes:
 etc/upgrade/upgrade-articles.in |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

- Log -----------------------------------------------------------------
commit 4d2a816cfa1543b17b9661daaf6b7f3b2fd4f13e
Author: Emmanuel Lacour <elacour at easter-eggs.com>
Date:   Thu May 26 09:47:19 2011 +0200

    Remove extra paren added in previous commit has we are already in a block and our local doesn't hurt second part of this block.
    
    (else we need to move "my $transactions" so it is defined for the whole block)

diff --git a/etc/upgrade/upgrade-articles.in b/etc/upgrade/upgrade-articles.in
index ee41f20..5eb9c83 100644
--- a/etc/upgrade/upgrade-articles.in
+++ b/etc/upgrade/upgrade-articles.in
@@ -231,7 +231,6 @@ sub copy_tables {
     # which called CurrentUserCanSee which calls Object which tries to instantiate
     # an RT::FM::Article.  Rather than a shim RT::FM::Article class, I'm just avoiding
     # the ACL check since we're running around as the superuser.
-    {
     local *RT::Transaction::Type = sub { shift->__Value('Type') };
     my $transactions = RT::Transactions->new(RT->SystemUser);
     $transactions->Limit( FIELD => 'ObjectType', VALUE => 'RT::FM::Article' );
@@ -239,7 +238,6 @@ sub copy_tables {
         my ($ret, $msg) = $t->__Set( Field => 'ObjectType', Value => 'RT::Article' );
         warn "Updated Transaction ".$t->Id." to point to RT::Article";
     }
-    }
 
     # we also need to change links that point to articles
     $transactions = RT::Transactions->new(RT->SystemUser);

-----------------------------------------------------------------------


More information about the Rt-commit mailing list