[Rt-commit] rt branch, 4.2/user-set-disabled-error, created. rt-4.0.0rc7-253-g52c9ece

Ruslan Zakirov ruz at bestpractical.com
Fri May 27 14:56:30 EDT 2011


The branch, 4.2/user-set-disabled-error has been created
        at  52c9eceb4c0511e3add199055bc594543746d7b8 (commit)

- Log -----------------------------------------------------------------
commit 52c9eceb4c0511e3add199055bc594543746d7b8
Author: Ruslan Zakirov <ruz at bestpractical.com>
Date:   Fri May 27 22:54:58 2011 +0400

    return error message when we fail to set disabled

diff --git a/lib/RT/User.pm b/lib/RT/User.pm
index 1570afd..f9645b7 100644
--- a/lib/RT/User.pm
+++ b/lib/RT/User.pm
@@ -1059,11 +1059,11 @@ sub SetDisabled {
     }
 
     $RT::Handle->BeginTransaction();
-    my $set_err = $self->PrincipalObj->SetDisabled($val);
-    unless ($set_err) {
+    my ($status, $msg) = $self->PrincipalObj->SetDisabled($val);
+    unless ($status) {
         $RT::Handle->Rollback();
         $RT::Logger->warning(sprintf("Couldn't %s user %s", ($val == 1) ? "disable" : "enable", $self->PrincipalObj->Id));
-        return (undef);
+        return ($status, $msg);
     }
     $self->_NewTransaction( Type => ($val == 1) ? "Disabled" : "Enabled" );
 

-----------------------------------------------------------------------


More information about the Rt-commit mailing list