[Rt-commit] rt branch, 4.0/articles-sorting-by-clicking-columns, created. rt-4.0.4-80-g3b44cbe

Ruslan Zakirov ruz at bestpractical.com
Tue Nov 29 17:06:02 EST 2011


The branch, 4.0/articles-sorting-by-clicking-columns has been created
        at  3b44cbea866cedaddb848b540e49744db631e765 (commit)

- Log -----------------------------------------------------------------
commit 7df119f9eca9a2b4bfb8dfe6c940c3c6cd2d1a0a
Author: Ruslan Zakirov <ruz at bestpractical.com>
Date:   Wed Nov 30 01:41:29 2011 +0400

    Order and OrderBy should be both arrays, no mix allowed
    
    if Order is a single value then in %ARGS it's scalar.

diff --git a/share/html/Articles/Article/Search.html b/share/html/Articles/Article/Search.html
index 7da34d2..1794695 100644
--- a/share/html/Articles/Article/Search.html
+++ b/share/html/Articles/Article/Search.html
@@ -243,7 +243,7 @@ my $customfields = RT::CustomFields->new( $session{'CurrentUser'} );
 my %dates;
 
 $articles->Search( %ARGS, CustomFields => $customfields, Dates => \%dates,
-        OrderBy => \@OrderBy );
+    OrderBy => \@OrderBy, Order => \@Order, );
 
 $m->callback( %ARGS, _Search => $articles );
 

commit 3b44cbea866cedaddb848b540e49744db631e765
Author: Ruslan Zakirov <ruz at bestpractical.com>
Date:   Wed Nov 30 01:46:33 2011 +0400

    we should pass Order* args to CollectionList
    
    if we don't do this then clicking on columns' header
    sorts only in one direction and never reverses.

diff --git a/share/html/Articles/Article/Search.html b/share/html/Articles/Article/Search.html
index 1794695..1f0b1c0 100644
--- a/share/html/Articles/Article/Search.html
+++ b/share/html/Articles/Article/Search.html
@@ -82,6 +82,8 @@
 <& /Elements/CollectionList,
     Collection => $articles, 
     AllowSorting => 1,
+    OrderBy => \@OrderBy,
+    Order => \@Order,
     Format => $format,
     GenericQueryArgs => { %filtered, Format => $format, },
     &>

-----------------------------------------------------------------------


More information about the Rt-commit mailing list