[Rt-commit] rt branch, 4.0/jumbo-autocomplete, updated. rt-4.0.2-43-g9702bf5

[Jason May]

The branch, 4.0/jumbo-autocomplete has been updated
       via  9702bf5b50cdf14b5280f2dc815a2646e4d899dd (commit)
       via  02b10b3cb9f3294e9443e42dfda821819315dff1 (commit)
       via  3572d91bacc2f0170f4e215d2265e9684b96d9f6 (commit)
      from  baa5e21719adb55d7edcbab559f0eb8e1339a185 (commit)

Summary of changes:
 lib/RT/Interface/Web.pm          |    4 +++-
 share/html/Ticket/ModifyAll.html |    4 ++--
 2 files changed, 5 insertions(+), 3 deletions(-)

- Log -----------------------------------------------------------------
commit 3572d91bacc2f0170f4e215d2265e9684b96d9f6
Author: Jason May <jasonmay at bestpractical.com>
Date:   Fri Oct 14 17:42:53 2011 -0400

    Check for numericalness on the correct variable

diff --git a/share/html/Ticket/ModifyAll.html b/share/html/Ticket/ModifyAll.html
index 176eb30..4e7010e 100755
--- a/share/html/Ticket/ModifyAll.html
+++ b/share/html/Ticket/ModifyAll.html
@@ -188,7 +188,7 @@ unless ($OnlySearchForPeople or $OnlySearchForGroup or $ARGS{'AddMoreAttach'} )
         my @owners =@{$ARGS{'Owner'}};
         delete $ARGS{'Owner'};
         foreach my $owner(@owners){
-            if ($ARGS{'Owner'} =~ /\D/) {
+            if ($owner =~ /\D/) {
                 $ARGS{'Owner'} = $owner unless ($Ticket->OwnerObj->Name eq $owner);
             }
             else {

commit 02b10b3cb9f3294e9443e42dfda821819315dff1
Author: Jason May <jasonmay at bestpractical.com>
Date:   Fri Oct 14 20:46:02 2011 -0400

    Perform some defined-ness checks on the owner name/id
    
    This silences a warning when an empty owner is submitted on the jumbo
    page.

diff --git a/share/html/Ticket/ModifyAll.html b/share/html/Ticket/ModifyAll.html
index 4e7010e..9ca4ccb 100755
--- a/share/html/Ticket/ModifyAll.html
+++ b/share/html/Ticket/ModifyAll.html
@@ -188,10 +188,10 @@ unless ($OnlySearchForPeople or $OnlySearchForGroup or $ARGS{'AddMoreAttach'} )
         my @owners =@{$ARGS{'Owner'}};
         delete $ARGS{'Owner'};
         foreach my $owner(@owners){
-            if ($owner =~ /\D/) {
+            if (defined($owner) && $owner =~ /\D/) {
                 $ARGS{'Owner'} = $owner unless ($Ticket->OwnerObj->Name eq $owner);
             }
-            else {
+            elsif (length $owner) {
                 $ARGS{'Owner'} = $owner unless ($Ticket->OwnerObj->id == $owner);
             }
         }

commit 9702bf5b50cdf14b5280f2dc815a2646e4d899dd
Author: Jason May <jasonmay at bestpractical.com>
Date:   Fri Oct 14 21:11:45 2011 -0400

    Check that the owner arg is an integer before comparing numerically
    
    This silences a warning when a user has AutocompleteOwners enabled and
    submits an owner that doesn't exist (which fails to load any sort of
    user and leaves the string untouched).

diff --git a/lib/RT/Interface/Web.pm b/lib/RT/Interface/Web.pm
index ab2830f..cb62e73 100644
--- a/lib/RT/Interface/Web.pm
+++ b/lib/RT/Interface/Web.pm
@@ -2024,7 +2024,9 @@ sub ProcessTicketBasics {
     );
 
     # We special case owner changing, so we can use ForceOwnerChange
-    if ( $ARGSRef->{'Owner'} && ( $OrigOwner != $ARGSRef->{'Owner'} ) ) {
+    if ( $ARGSRef->{'Owner'}
+      && $ARGSRef->{'Owner'} !~ /\D/
+      && ( $OrigOwner != $ARGSRef->{'Owner'} ) ) {
         my ($ChownType);
         if ( $ARGSRef->{'ForceOwnerChange'} ) {
             $ChownType = "Force";

-----------------------------------------------------------------------