[Rt-commit] rt branch, 4.2/attach-from-transactions, updated. rt-4.0.1-406-gdbcab60

[Thomas Sibley]

The branch, 4.2/attach-from-transactions has been updated
       via  dbcab6000ccbac84d41ae7173a1735c9dcb2aaa0 (commit)
      from  ae16e9720470778211f6b6802413a8417506104b (commit)

Summary of changes:
 share/html/Ticket/Elements/AddAttachments |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

- Log -----------------------------------------------------------------
commit dbcab6000ccbac84d41ae7173a1735c9dcb2aaa0
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Wed Oct 19 13:24:14 2011 -0400

    Move the link out of the label so clicking doesn't both open the attachment and select it for inclusion
    
    I'm not thrilled by the (View) solution, but I'm at a loss for something
    better at the moment.  The filename _should_ be the checkbox label, and
    clicking it should tick the checkbox, but not necessarily open the
    attachment.

diff --git a/share/html/Ticket/Elements/AddAttachments b/share/html/Ticket/Elements/AddAttachments
index aeec6a2..04a4c40 100644
--- a/share/html/Ticket/Elements/AddAttachments
+++ b/share/html/Ticket/Elements/AddAttachments
@@ -67,13 +67,15 @@
     <label>
       <input type="checkbox" class="checkbox" name="AttachExisting" value="<% $attach->Id %>" \
              <% (grep { $attach->Id == $_ } @AttachExisting) ? 'checked' : '' %> />
+      <% $attach->Filename %>
+    </label>
 <%perl>
 my $url = sprintf '%s/Ticket/Attachment/%d/%d/%s',
             RT->Config->Get('WebPath'), $attach->TransactionObj->Id, $attach->Id,
             $m->interp->apply_escapes($attach->Filename, 'u');
 </%perl>
-      <a href="<% $url %>" target="_blank"><% $attach->Filename %></a>
-    </label><br />
+      (<a href="<% $url %>" target="_blank"><&|/l&>View</&></a>)
+      <br />
 %     }
   </td>
 </tr>

-----------------------------------------------------------------------