[Rt-commit] rtir branch, 2.9-trunk, updated. 2.6.1-537-g3fdf53c

[Ruslan Zakirov]

The branch, 2.9-trunk has been updated
       via  3fdf53c8da9e9545ebac8e0bb38602a4ff874521 (commit)
       via  d63eb6e9ce1327e1d297e09dc06eade88808ab5e (commit)
      from  2af1c59b656fc58d5f7f0e1a7d6198fe801a6a19 (commit)

Summary of changes:
 TODO.porting_over_RT4                       |   17 -----------------
 html/RTIR/Tools/Elements/ToolFormIframe     |    2 +-
 html/RTIR/Tools/Elements/ToolFormTraceroute |    2 +-
 html/RTIR/Tools/Elements/ToolFormWhois      |    2 +-
 html/RTIR/Tools/Lookup.html                 |    2 +-
 html/RTIR/Tools/ScriptedAction.html         |    8 ++++----
 6 files changed, 8 insertions(+), 25 deletions(-)
 delete mode 100644 TODO.porting_over_RT4

- Log -----------------------------------------------------------------
commit d63eb6e9ce1327e1d297e09dc06eade88808ab5e
Author: Ruslan Zakirov <ruz at bestpractical.com>
Date:   Thu Oct 27 21:48:23 2011 +0400

    get rid of uninit warnings when we walk web
    
    covers t/walk-web.t, so walking default menu
    doesn't result in warnings

diff --git a/html/RTIR/Tools/Elements/ToolFormIframe b/html/RTIR/Tools/Elements/ToolFormIframe
index bbd985e..9e5ccbf 100644
--- a/html/RTIR/Tools/Elements/ToolFormIframe
+++ b/html/RTIR/Tools/Elements/ToolFormIframe
@@ -14,7 +14,7 @@
     <input type="submit" value="<%loc('Go')%>" />
 </form>
 <%args>
-$q => undef
+$q => ''
 $ResearchTool => ''
 @PassArguments => ()
 </%args>
diff --git a/html/RTIR/Tools/Elements/ToolFormTraceroute b/html/RTIR/Tools/Elements/ToolFormTraceroute
index 335f1c4..a72411d 100644
--- a/html/RTIR/Tools/Elements/ToolFormTraceroute
+++ b/html/RTIR/Tools/Elements/ToolFormTraceroute
@@ -4,5 +4,5 @@
     <input type="submit" value="<%loc('Go')%>" />
 </form>
 <%args>
-$q => undef
+$q => ''
 </%args>
diff --git a/html/RTIR/Tools/Elements/ToolFormWhois b/html/RTIR/Tools/Elements/ToolFormWhois
index 386dc3b..7e4053d 100644
--- a/html/RTIR/Tools/Elements/ToolFormWhois
+++ b/html/RTIR/Tools/Elements/ToolFormWhois
@@ -10,7 +10,7 @@
   <input type="submit" value="<%loc('Go')%>" />
 </form>
 <%args>
-$q => undef
+$q => ''
 $WhoisServer => undef
 $server => undef
 @PassArguments => ()
diff --git a/html/RTIR/Tools/Lookup.html b/html/RTIR/Tools/Lookup.html
index bd616f0..cfdae4b 100644
--- a/html/RTIR/Tools/Lookup.html
+++ b/html/RTIR/Tools/Lookup.html
@@ -75,7 +75,7 @@ if ( $ticket ) {
 
 </%INIT>
 <%ARGS>
-$q         => undef
+$q         => ''
 $type      => undef
 $ticket    => undef
 $HideResults => 0
diff --git a/html/RTIR/Tools/ScriptedAction.html b/html/RTIR/Tools/ScriptedAction.html
index 0beac1b..05e7b33 100644
--- a/html/RTIR/Tools/ScriptedAction.html
+++ b/html/RTIR/Tools/ScriptedAction.html
@@ -60,7 +60,7 @@
   </tr>
   <tr>
     <td class="label"><&|/l&>Contact Field</&>:</td>
-    <td class="value"><input type="text" name="field" value="<% $ARGS{'field'} %>" /></td>
+    <td class="value"><input type="text" name="field" value="<% $ARGS{'field'} || '' %>" /></td>
   </tr>
   <tr>
     <td class="label">
@@ -89,13 +89,13 @@
 <tr>
   <td class="label"><&|/l&>Template</&>:</td>
   <td class="value">
-    <& /Admin/Elements/SelectTemplate, Name => "Template", Default => $ARGS{'Template'}, Queue => $investigationq->Id &>
+    <& /Admin/Elements/SelectTemplate, Name => "Template", Default => $ARGS{'Template'} || 0, Queue => $investigationq->Id &>
   </td>
 </tr>
 <tr>
   <td class="label"><&|/l&>Argument</&>:</td>
   <td class="value">
-    <input type="text" name="TemplateArg" size="60" value="<% $ARGS{'TemplateArg'} %>" />
+    <input type="text" name="TemplateArg" size="60" value="<% $ARGS{'TemplateArg'} || '' %>" />
   </td>
 </tr>
 </table>
@@ -404,7 +404,7 @@ sub parse_csv {
 </%INIT>
 
 <%ARGS>
-$incidentid => undef
+$incidentid => 0
 $server => undef
 $loop => 'address'
 </%ARGS>

commit 3fdf53c8da9e9545ebac8e0bb38602a4ff874521
Author: Ruslan Zakirov <ruz at bestpractical.com>
Date:   Thu Oct 27 21:49:46 2011 +0400

    moved rest of TODO to issues.bestpractical.com

diff --git a/TODO.porting_over_RT4 b/TODO.porting_over_RT4
deleted file mode 100644
index fb5c4bc..0000000
--- a/TODO.porting_over_RT4
+++ /dev/null
@@ -1,17 +0,0 @@
-=== DOCS
-
-* Review tutorials in context of lifecycles.
-
-=== BRINGING UP TO DATE
-
-* Some pages with forms need new nice layouts like in RT, reply
-  page comes first to mind
-** go over most common pages and look at layouts
-
-=== TESTS
-
-We walk the web, but there is no single functionality test for:
-    .../Link/FromIncident/index.html
-    .../Search/Reporting.html
-    .../Reporting/index.html
-    .../Split.html

-----------------------------------------------------------------------