[Rt-commit] rt branch, 4.2/date-time-improvements-in-charts, updated. rt-3.8.10-122-gc99666c

Ruslan Zakirov ruz at bestpractical.com
Sun Sep 11 03:29:25 EDT 2011


The branch, 4.2/date-time-improvements-in-charts has been updated
       via  c99666c85d92e9cd4d8ec0f03739fce8fd96c61f (commit)
       via  e1cb641bee1ab0fb44bd303fe8398680d6f3a16a (commit)
      from  7fc00ce1e2e89df9887ad92461cf4d11d9d87599 (commit)

Summary of changes:
 lib/RT/Report/Tickets.pm |    8 +++++---
 1 files changed, 5 insertions(+), 3 deletions(-)

- Log -----------------------------------------------------------------
commit e1cb641bee1ab0fb44bd303fe8398680d6f3a16a
Author: Ruslan Zakirov <ruz at bestpractical.com>
Date:   Sat Sep 10 20:06:36 2011 +0400

    rename method, better purpose description
    
    s/CalculatePostFunctions/PostProcessRecords/

diff --git a/lib/RT/Report/Tickets.pm b/lib/RT/Report/Tickets.pm
index 95985f3..9c71d96 100644
--- a/lib/RT/Report/Tickets.pm
+++ b/lib/RT/Report/Tickets.pm
@@ -529,7 +529,7 @@ sub _DoSearch {
         );
     }
     else {
-        $self->CalculatePostFunctions;
+        $self->PostProcessRecords;
     }
 }
 
@@ -640,7 +640,7 @@ sub SortEntries {
     ];
 } }
 
-sub CalculatePostFunctions {
+sub PostProcessRecords {
     my $self = shift;
 
     my $info = $self->{'column_info'};

commit c99666c85d92e9cd4d8ec0f03739fce8fd96c61f
Author: Ruslan Zakirov <ruz at bestpractical.com>
Date:   Sat Sep 10 20:09:38 2011 +0400

    display function shouldn't change argument

diff --git a/lib/RT/Report/Tickets.pm b/lib/RT/Report/Tickets.pm
index 9c71d96..6a326a3 100644
--- a/lib/RT/Report/Tickets.pm
+++ b/lib/RT/Report/Tickets.pm
@@ -239,10 +239,12 @@ my $duration_to_string_cb = sub {
     }
 
     my $date = RT::Date->new( $self->CurrentUser );
-    foreach my $e ( values %$v ) {
+    my %res = %$v;
+    foreach my $e ( values %res ) {
         $e = $date->DurationAsString( $e ) if defined $e && length $e;
         $e = $self->loc("(no value)") unless defined $e && length $e;
     }
+    return \%res;
 };
 
 our %STATISTICS_META = (

-----------------------------------------------------------------------


More information about the Rt-commit mailing list