[Rt-commit] rt branch, 4.0/skip-empty-values-in-email-completion, created. rt-4.0.5-117-g3c678fc

? sunnavy sunnavy at bestpractical.com
Sun Apr 15 05:16:02 EDT 2012


The branch, 4.0/skip-empty-values-in-email-completion has been created
        at  3c678fc8928385d36fded38eea6ee392b06ae647 (commit)

- Log -----------------------------------------------------------------
commit 3c678fc8928385d36fded38eea6ee392b06ae647
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Sun Apr 15 17:13:45 2012 +0800

    skip empty values as it returns nothing in completion
    
    see #19778

diff --git a/share/html/Helpers/Autocomplete/Users b/share/html/Helpers/Autocomplete/Users
index dbc2d88..d1dc69a 100644
--- a/share/html/Helpers/Autocomplete/Users
+++ b/share/html/Helpers/Autocomplete/Users
@@ -120,6 +120,8 @@ while ( my $user = $users->Next ) {
     next if $user->id == RT->SystemUser->id
          or $user->id == RT->Nobody->id;
 
+    next unless defined $user->$return && length $user->$return;
+
     my $formatted = $m->scomp('/Elements/ShowUser', User => $user, NoEscape => 1);
     $formatted =~ s/\n//g;
     my $suggestion = { label => $formatted, value => $user->$return };

-----------------------------------------------------------------------


More information about the Rt-commit mailing list