[Rt-commit] rt branch, 4.0/test-dependencies-conclusion-with-install, updated. rt-4.0.5-62-gdb53742

Thomas Sibley trs at bestpractical.com
Wed Apr 25 09:25:42 EDT 2012


The branch, 4.0/test-dependencies-conclusion-with-install has been updated
       via  db53742112f697ea86c8857620f1997299496ffe (commit)
      from  d84d60270c6d7f1a3aa76829a86ec730ce3b61b1 (commit)

Summary of changes:
 sbin/rt-test-dependencies.in |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

- Log -----------------------------------------------------------------
commit db53742112f697ea86c8857620f1997299496ffe
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Wed Apr 25 09:23:07 2012 -0400

    Reliably negate --install when automatically re-running rt-test-dependencies
    
    The --install option might be spelled -i or any number of other ways
    thanks to getopt.  Instead of trying to fish for all the variations,
    make the flag negatable and negate it as the last arg.

diff --git a/sbin/rt-test-dependencies.in b/sbin/rt-test-dependencies.in
index 0ddab2e..313fc35 100755
--- a/sbin/rt-test-dependencies.in
+++ b/sbin/rt-test-dependencies.in
@@ -59,7 +59,7 @@ my %deps;
 my @orig_argv = @ARGV;
 GetOptions(
     \%args,                               'v|verbose',
-    'install',                            'with-MYSQL',
+    'install!',                           'with-MYSQL',
     'with-POSTGRESQL|with-pg|with-pgsql', 'with-SQLITE',
     'with-ORACLE',                        'with-FASTCGI',
     'with-MODPERL1',                      'with-MODPERL2',
@@ -404,7 +404,7 @@ foreach my $type (sort grep $args{$_}, keys %args) {
 }
 
 if ( $args{'install'} && keys %Missing_By_Type ) {
-    exec($0, grep { $_ ne '--install' } @orig_argv );
+    exec($0, @orig_argv, '--no-install');
 }
 else {
     conclude(%Missing_By_Type);

-----------------------------------------------------------------------


More information about the Rt-commit mailing list