[Rt-commit] rt branch, 4.2/mailgate-errors, created. rt-4.0.6-446-gb1b02b1

[Thomas Sibley]

The branch, 4.2/mailgate-errors has been created
        at  b1b02b185daf4467a16032b404b57e7f8199473e (commit)

- Log -----------------------------------------------------------------
commit b1b02b185daf4467a16032b404b57e7f8199473e
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Tue Jul 31 09:53:28 2012 -0700

    Provide a more helpful error from rt-mailgate when the POST fails
    
    Based on anecdotal evidence from rt-bugs and rt-users, the most commonly
    encountered errors are improperly configured RT servers returning 500
    and network timeouts.

diff --git a/bin/rt-mailgate.in b/bin/rt-mailgate.in
index da6f757..b9c09ab 100755
--- a/bin/rt-mailgate.in
+++ b/bin/rt-mailgate.in
@@ -244,13 +244,8 @@ sub check_failure {
     my $r    = shift;
     return if $r->is_success;
 
-    # XXX TODO 4.2: Remove the multi-line error strings in favor of something more concise
-    print STDERR <<"    ERROR";
-An Error Occurred
-=================
-
-@{[ $r->status_line ]}
-    ERROR
+    print STDERR "HTTP request failed: @{[ $r->status_line ]}. "
+                ."Your webserver logs may have more information or there may be a network problem.\n";
     print STDERR "\n$0: undefined server error\n" if $opts->{'debug'};
     return $self->tempfail();
 }

-----------------------------------------------------------------------