[Rt-commit] rt branch, 3.8/test-compat, created. rt-3.8.15-3-g7468211

[Alex Vandiver]

The branch, 3.8/test-compat has been created
        at  7468211183374b1ee3c10af8424cd2abcdd4742b (commit)

- Log -----------------------------------------------------------------
commit 4cc16ab75401bd5e2feaa7ff01b27b60ec37c6f8
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Wed Dec 12 19:46:06 2012 -0500

    Remove bogus argument to ->get(), which fail on HTTP::Message >= 5.05
    
    The documentation for ->get states:
    
        $ua->get( $url , $field_name => $value, ... )
    
    The later arguments are expected to be headers which will be added to
    the request, via HTTP::Request, which isa HTTP::Message.  Hence,
    t/web/compilation_errors.t was adding a bogus header whose _name_ was
    "GET http://server:port/path" and whose value was undef.  HTTP::Message
    5.05 rightly errors on being passed this, complaining:
    
        Illegal field name 'GET http://localhost:7582//index.html'
    
    Remove the bogus second argument to ->get, which has been present since
    e1f253e.

diff --git a/t/web/compilation_errors.t b/t/web/compilation_errors.t
index 36a0068..ab69978 100644
--- a/t/web/compilation_errors.t
+++ b/t/web/compilation_errors.t
@@ -48,7 +48,7 @@ sub test_get {
 
         $file =~ s#^share/html/##;
         diag( "testing $url/$file" ) if $ENV{TEST_VERBOSE};
-        ok ($agent->get("$url/$file", "GET $url/$file"), "Can Get $url/$file");
+        ok ($agent->get("$url/$file"), "Can Get $url/$file");
         is ($agent->{'status'}, 200, "Loaded $file");
 #        ok( $agent->{'content'} =~ /Logout/i, "Found a logout link on $file ");
         ok( $agent->{'content'} !~ /Not logged in/i, "Still logged in for  $file");

commit 7468211183374b1ee3c10af8424cd2abcdd4742b
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Wed Dec 12 19:54:17 2012 -0500

    Ensure that tickets are destroyed before global destruction, in more recent perl
    
    Perl 5.14 and above undergo global destruction in a different order,
    causing tests to fail because of disorderly teardown and transaction
    batch.  Explicitly clear out @tickets to ensure that they do not get
    DESTROYed during global destruction.

diff --git a/t/ticket/search_by_links.t b/t/ticket/search_by_links.t
index a8e955c..383f376 100644
--- a/t/ticket/search_by_links.t
+++ b/t/ticket/search_by_links.t
@@ -130,3 +130,4 @@ my $pid = $tickets[1]->id;
 }
 run_tests();
 
+ at tickets = ();
diff --git a/t/ticket/search_by_watcher.t b/t/ticket/search_by_watcher.t
index 9d94432..445c61e 100644
--- a/t/ticket/search_by_watcher.t
+++ b/t/ticket/search_by_watcher.t
@@ -276,5 +276,4 @@ my $nobody = RT::Nobody();
     is($tix->Count, 2, "found ticket(s)");
 }
 
-
-exit(0)
+ at tickets = ();

-----------------------------------------------------------------------