[Rt-commit] rt branch, 4.0/repair-simplified-recipients-table, created. rt-4.0.8-248-g08dbc27

[Kevin Falcone]

The branch, 4.0/repair-simplified-recipients-table has been created
        at  08dbc2766c759306eb0780356ff7600e1839fe2b (commit)

- Log -----------------------------------------------------------------
commit 08dbc2766c759306eb0780356ff7600e1839fe2b
Author: Kevin Falcone <falcone at bestpractical.com>
Date:   Fri Dec 14 15:54:45 2012 -0800

    This table was being generated incorrectly.
    
    We put out <table><tr></tr>...</tr>...</tr></table>
    Pushing the <tr> inside the loop generates the <tr></tr> we
    were aiming for.  Browsers seem to just detect and fix this for us.

diff --git a/share/html/Ticket/Elements/ShowSimplifiedRecipients b/share/html/Ticket/Elements/ShowSimplifiedRecipients
index 590006b..8119fa9 100644
--- a/share/html/Ticket/Elements/ShowSimplifiedRecipients
+++ b/share/html/Ticket/Elements/ShowSimplifiedRecipients
@@ -76,9 +76,9 @@ my %recips;
 </%init>
 <&|/Widgets/TitleBox, title => loc('Recipients'), id => 'recipients' &>
 <table>
-<tr>
 % for my $type (qw(To Cc Bcc)) {
 %     next unless keys %{$headers{$type}};
+<tr>
 <td valign="top"><% $type %>:</td>
 <td valign="top">
 %     for my $addr (sort {$a->address cmp $b->address} values %{$headers{$type}}) {

-----------------------------------------------------------------------