[Rt-commit] rt branch, 4.0/add-approvals-doc, updated. rt-4.0.6-279-ga20fb43

[Thomas Sibley]

The branch, 4.0/add-approvals-doc has been updated
       via  a20fb4359177df611c3277bf422107c1b20efb6b (commit)
       via  0099bbb5722ab77249966714ed40b645e7c51256 (commit)
       via  0accd3a3add8c458494aa2a7c31b5ebb2b6b5922 (commit)
       via  29ae26402bbb40800bba645ab0a6749ca7a3c868 (commit)
      from  ee8d7da487f33187b5b0ebe63ae5b1e1fdfa9c38 (commit)

Summary of changes:
 docs/customizing/approvals.pod | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

- Log -----------------------------------------------------------------
commit 29ae26402bbb40800bba645ab0a6749ca7a3c868
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Tue Dec 18 13:36:04 2012 -0800

    Reiterate that ___Approvals is special
    
    Try to squash desires to rename it.

diff --git a/docs/customizing/approvals.pod b/docs/customizing/approvals.pod
index 964ae7a..e057e8e 100644
--- a/docs/customizing/approvals.pod
+++ b/docs/customizing/approvals.pod
@@ -14,7 +14,7 @@ set up approvals.
 
 =head2 Overview
 
-The approvals solution in RT involves using another queue,
+The approvals solution in RT involves using a special queue,
 called ___Approvals, to hold approval requests. Scrips and
 templates automatically create the necessary tickets
 and process the approval or rejection.
@@ -99,6 +99,10 @@ area and enter ___Approvals into the search
 field. Check 'Include disabled queues in listing.' and click Go!
 You should now see the ___Approvals queue configuration page.
 
+You may want to change the name of the ___Approvals queue, but parts of RT
+expect it not to change.  The name normally isn't shown to users, however, so
+it will be largely invisible.
+
 =head2 Approvals' templates
 
 From the ___Approvals queue configuration page, click 'Templates' in the

commit 0accd3a3add8c458494aa2a7c31b5ebb2b6b5922
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Tue Dec 18 13:37:14 2012 -0800

    Content: must start on the first line for CreateTickets templates

diff --git a/docs/customizing/approvals.pod b/docs/customizing/approvals.pod
index e057e8e..18376e5 100644
--- a/docs/customizing/approvals.pod
+++ b/docs/customizing/approvals.pod
@@ -46,9 +46,9 @@ leave the default Type as Perl and in the content area enter the following:
     Type: approval
     Content-Type: text/plain
     Due: {time + 3*24*60*60}
-    Content:
+    Content: Please approve me.
 
-    Please approve me
+    Thanks.
     ENDOFCONTENT
 
 All of the text should be against the left side of the textarea

commit 0099bbb5722ab77249966714ed40b645e7c51256
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Tue Dec 18 13:37:55 2012 -0800

    Typo

diff --git a/docs/customizing/approvals.pod b/docs/customizing/approvals.pod
index 18376e5..3109e00 100644
--- a/docs/customizing/approvals.pod
+++ b/docs/customizing/approvals.pod
@@ -70,7 +70,7 @@ action, and select the template you just created. Click create.
 You can already test your first workflow with approvals. Create
 a ticket in your new 'Change requests' queue. You're logged in as
 'root' and the owner of the approval is root (based on the template),
-so it's your job to approve or deny the reuqest. Select Tools -> Approvals
+so it's your job to approve or deny the request. Select Tools -> Approvals
 in the RT main menu. You should see your first approval request.
 
 Select the 'Deny' radio button, write 'too expensive' in the notes area

commit a20fb4359177df611c3277bf422107c1b20efb6b
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Tue Dec 18 13:38:26 2012 -0800

    Correct an approval notification misconception (due to a bug)
    
    See [rt3 #20999].  Despite what the template description claims, the
    rules code which uses New Pending Approval currently only notifies the
    Owner.

diff --git a/docs/customizing/approvals.pod b/docs/customizing/approvals.pod
index 3109e00..4f768f7 100644
--- a/docs/customizing/approvals.pod
+++ b/docs/customizing/approvals.pod
@@ -115,7 +115,7 @@ the correspondence mentioned above.
 
 =item * New Pending Approval
 
-Owners and AdminCcs of a new approval requests get this message.
+Owners of new approval requests get this message.
 
 =item * Approval Passed
 

-----------------------------------------------------------------------