[Rt-commit] rt branch, 4.0/fix-admin-delete-cf-values, created. rt-4.0.8-301-gd5bc269

[? sunnavy]

The branch, 4.0/fix-admin-delete-cf-values has been created
        at  d5bc26912534315361fb0a0d0833d62c4e9b5300 (commit)

- Log -----------------------------------------------------------------
commit d5bc26912534315361fb0a0d0833d62c4e9b5300
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Wed Dec 26 10:53:52 2012 +0800

    /o is wrong here since $paramtag could change
    
    if we delete a value for a cf and then do the same thing for another cf, the
    2nd try will fail because of /o, see #21813

diff --git a/share/html/Admin/CustomFields/Modify.html b/share/html/Admin/CustomFields/Modify.html
index 1dbc47f..d18ec2f 100644
--- a/share/html/Admin/CustomFields/Modify.html
+++ b/share/html/Admin/CustomFields/Modify.html
@@ -234,7 +234,7 @@ if ( $ARGS{'Update'} && $id ne 'new' ) {
     my $paramtag = "CustomField-". $CustomFieldObj->Id ."-Value";
     # Delete any fields that want to be deleted
     foreach my $key ( keys %ARGS ) {
-        next unless $key =~ /^Delete-$paramtag-(\d+)$/o;
+        next unless $key =~ /^Delete-$paramtag-(\d+)$/;
         my ($val, $msg) = $CustomFieldObj->DeleteValue( $1 );
         push (@results, $msg);
     }

-----------------------------------------------------------------------