[Rt-commit] rt branch, 4.2/fix-chmod-in-install-page, created. rt-4.0.4-302-g195cd24

[? sunnavy]

The branch, 4.2/fix-chmod-in-install-page has been created
        at  195cd242b7e3f5889a58606bb34eb2dfe581a25a (commit)

- Log -----------------------------------------------------------------
commit 195cd242b7e3f5889a58606bb34eb2dfe581a25a
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Mon Jan 16 21:43:28 2012 +0800

    use "chmod 555" as "chmod -w" is affected by umask.
    
    umask(0077) in RT::Interface::Web::Handler::InitSessionDir makes
    group part get ignored, which fails t/web/install.t
    
    besides, perl has chmod itself, no need to use heavy system call

diff --git a/share/html/Install/Finish.html b/share/html/Install/Finish.html
index e567b3f..2fe52fe 100644
--- a/share/html/Install/Finish.html
+++ b/share/html/Install/Finish.html
@@ -79,9 +79,11 @@ if ( $Run ) {
     RT->InitClasses();
     RT->InitPlugins();
 
-    system( 'chmod -w ' . RT::Installer->ConfigFile ) &&
+    my $ret = chmod 0555, RT::Installer->ConfigFile;
+    if ( !$ret ) {
         $RT::Logger->error(
                 'failed to make ' . RT::Installer->ConfigFile . ' readonly' );
+    }
     my $root = RT::User->new( RT->SystemUser );
     $root->Load('root');
     my ($ok, $val) = $root->SetPassword( $RT::Installer->{InstallConfig}{Password} );

-----------------------------------------------------------------------