[Rt-commit] rt branch, 4.0/route-actions-via-update-page, created. rt-4.0.6-250-gcf04eda

[Ruslan Zakirov]

The branch, 4.0/route-actions-via-update-page has been created
        at  cf04eda074548bfd4df351f2c3bda554e8fea691 (commit)

- Log -----------------------------------------------------------------
commit cf04eda074548bfd4df351f2c3bda554e8fea691
Author: Ruslan Zakirov <ruz at bestpractical.com>
Date:   Sun Jul 15 20:16:56 2012 +0400

    point all status change actions to Update.html
    
    Quick actions are now routed to Display.html. It makes
    harder to implement variouse extensions that require
    users to fill CFs/core fields/etc when status is changed.
    
    These quick links should fall through Update.html to
    Display.html in vanilla RT and stay backwards compatible.
    
    It's not tested, just a stab.

diff --git a/share/html/Elements/Tabs b/share/html/Elements/Tabs
index a32cc01..cfee1c5 100755
--- a/share/html/Elements/Tabs
+++ b/share/html/Elements/Tabs
@@ -582,20 +582,14 @@ my $build_main_nav = sub {
 
                 my $action = $info->{'update'} || '';
                 my $url = '/Ticket/';
-                if ($action) {
-                    $url .= "Update.html?"
-                        . $query_string->(
-                            Action        => $action,
-                            DefaultStatus => $next,
-                            id            => $id,
-                        );
-                } else {
-                    $url .= "Display.html?"
-                        . $query_string->(
-                            Status => $next,
-                            id     => $id,
-                        );
-                }
+                $url .= "Update.html?"
+                    . $query_string->(
+                        $action
+                            ? (Action        => $action),
+                            : (SubmitTicket  => 1),
+                        DefaultStatus => $next,
+                        id            => $id,
+                    );
                 my $key = $info->{'label'} || ucfirst($next);
                 $actions->child( $key => title => loc( $key ), path => $url);
             }

-----------------------------------------------------------------------