[Rt-commit] rt branch, 4.0/rest-drop-wrong-email-test, created. rt-4.0.6-250-g8a34dc3

Ruslan Zakirov ruz at bestpractical.com
Tue Jul 17 11:09:45 EDT 2012


The branch, 4.0/rest-drop-wrong-email-test has been created
        at  8a34dc3b97551c341130863806c8f3454ad0b946 (commit)

- Log -----------------------------------------------------------------
commit 8a34dc3b97551c341130863806c8f3454ad0b946
Author: Ruslan Zakirov <ruz at bestpractical.com>
Date:   Tue Jul 17 19:02:17 2012 +0400

    no need in this naive email check, it's wrong
    
    IsWatcher doesn't suffer from wrong email address.
    
    AddWatcher checks validity, whether it's RT's address
    and other things.

diff --git a/share/html/REST/1.0/Forms/ticket/default b/share/html/REST/1.0/Forms/ticket/default
index 032e6c9..016a50c 100755
--- a/share/html/REST/1.0/Forms/ticket/default
+++ b/share/html/REST/1.0/Forms/ticket/default
@@ -344,13 +344,6 @@ else {
                 }
             }
             foreach $p (keys %new) {
-                # XXX: This is a stupid test.
-                unless ($p =~ /^[\w.+-]+\@([\w.-]+\.)*\w+.?$/) {
-                    $s = 0;
-                    $n = "$p is not a valid email address.";
-                    push @msgs, [ $s, $n ];
-                    next;
-                }
                 unless ($ticket->IsWatcher(Type => $type, Email => $p)) {
                     ($s, $n) = $ticket->AddWatcher(Type => $type,
                                                    Email => $p);

-----------------------------------------------------------------------


More information about the Rt-commit mailing list