[Rt-commit] rt branch, 4.0/notify-group-upgrade, created. rt-4.0.6-126-g28a4d67

[Alex Vandiver]

The branch, 4.0/notify-group-upgrade has been created
        at  28a4d67077a0888b9aa5bfae76ec20f4c2a746ff (commit)

- Log -----------------------------------------------------------------
commit 28a4d67077a0888b9aa5bfae76ec20f4c2a746ff
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Tue Jun 5 15:44:53 2012 -0400

    Fix a join call which was mistakenly passed a regex instead of a string
    
    The code, as written, effectively joins with the empty string -- unless
    $_ happens to contain ", " in which case it joins with "1".  Though this
    statement should cause a compile-time warnin (/, / should probably be
    written as ", ") under "use warnings", upgrade scrips still mistakenly
    eat warnings.

diff --git a/etc/upgrade/3.8.4/content b/etc/upgrade/3.8.4/content
index 38d5514..14ecba4 100644
--- a/etc/upgrade/3.8.4/content
+++ b/etc/upgrade/3.8.4/content
@@ -45,7 +45,7 @@
             if ( my $struct = eval { Storable::thaw( $argument ) } ) {
                 $new = $converter->( $struct );
             } else {
-                $new = join /, /, grep length, split /[^0-9]+/, $argument;
+                $new = join ", ", grep length, split /[^0-9]+/, $argument;
             }
             next if $new eq $argument;
 

-----------------------------------------------------------------------