[Rt-commit] rt branch, 4.0/case-insensitive-custom-field-searching, created. rt-4.0.6-167-g668a869

Kevin Falcone falcone at bestpractical.com
Mon Jun 11 14:56:36 EDT 2012


The branch, 4.0/case-insensitive-custom-field-searching has been created
        at  668a8696e38cd1a845c081cae0d012a1e5666700 (commit)

- Log -----------------------------------------------------------------
commit 668a8696e38cd1a845c081cae0d012a1e5666700
Author: Kevin Falcone <falcone at bestpractical.com>
Date:   Mon Jun 11 14:08:43 2012 -0400

    Make CustomField TicketSQL queries case insensitive
    
    Before this, CF.{Foo} = 'bob' wouldn't result in a LOWER()
    being used on Pg or Oracle.  The tests added in b42a867f
    started exposing this.

diff --git a/lib/RT/Tickets.pm b/lib/RT/Tickets.pm
index a5fa74e..190872d 100644
--- a/lib/RT/Tickets.pm
+++ b/lib/RT/Tickets.pm
@@ -1679,6 +1679,7 @@ sub _CustomFieldLimit {
                         FIELD    => 'Content',
                         OPERATOR => $op,
                         VALUE    => $value,
+                        CASESENSITIVE => 0,
                         %rest
                     );
                 }
@@ -1689,7 +1690,8 @@ sub _CustomFieldLimit {
                         FIELD           => 'Content',
                         OPERATOR        => '=',
                         VALUE           => '',
-                        ENTRYAGGREGATOR => 'OR'
+                        ENTRYAGGREGATOR => 'OR',
+                        CASESENSITIVE => 0,
                     );
                     $self->_SQLLimit(
                         ALIAS           => $TicketCFs,
@@ -1705,6 +1707,7 @@ sub _CustomFieldLimit {
                         OPERATOR        => $op,
                         VALUE           => $value,
                         ENTRYAGGREGATOR => 'AND',
+                        CASESENSITIVE => 0,
                     ) );
                 }
             }
@@ -1714,6 +1717,7 @@ sub _CustomFieldLimit {
                     FIELD    => 'Content',
                     OPERATOR => $op,
                     VALUE    => $value,
+                    CASESENSITIVE => 0,
                     %rest
                 );
 
@@ -1740,6 +1744,7 @@ sub _CustomFieldLimit {
                     OPERATOR        => $op,
                     VALUE           => $value,
                     ENTRYAGGREGATOR => 'AND',
+                    CASESENSITIVE => 0,
                 ) );
                 $self->_CloseParen;
             }
@@ -1796,6 +1801,7 @@ sub _CustomFieldLimit {
                 FIELD      => $column,
                 OPERATOR   => $op,
                 VALUE      => $value,
+                CASESENSITIVE => 0,
             ) );
         }
         else {
@@ -1805,6 +1811,7 @@ sub _CustomFieldLimit {
                 FIELD      => 'Content',
                 OPERATOR   => $op,
                 VALUE      => $value,
+                CASESENSITIVE => 0,
             );
         }
         $self->_SQLLimit(

-----------------------------------------------------------------------


More information about the Rt-commit mailing list