[Rt-commit] rt branch, 4.0/scrip-lastupdated, created. rt-4.0.5-81-g244c807
Alex Vandiver
alexmv at bestpractical.com
Fri Mar 9 18:40:06 EST 2012
The branch, 4.0/scrip-lastupdated has been created
at 244c807eddc839120bde2340d83f35489b683ee8 (commit)
- Log -----------------------------------------------------------------
commit 244c807eddc839120bde2340d83f35489b683ee8
Author: Alex Vandiver <alexmv at bestpractical.com>
Date: Fri Mar 9 16:37:53 2012 -0500
Enable LastUpdated on Scrips by not walking around RT::Record->_Set
75ad51c, as part of a "security audit," moved RT::Scrip's ->_Set method
to call ->__Set, rather than ->SUPER::_Set; this means that it skips the
functionality on RT::Record->_Set. This skips the call to
->SetLastUpdated, causing all Scrips to never update their LastUpdated
ot LastUpdatedBy columns. Less importantly, it also skips the code
which makes the return message explicit as to the values which changed;
while not strictly a feature in this case, it is at least consistent
with Templates and the like.
Revert to calling ->SUPER::_Set, so Scrips' LastUpdated columns are kept
up-to-date.
diff --git a/lib/RT/Scrip.pm b/lib/RT/Scrip.pm
index 3e8f352..4ea04c0 100644
--- a/lib/RT/Scrip.pm
+++ b/lib/RT/Scrip.pm
@@ -519,7 +519,7 @@ sub _Set {
}
}
- return $self->__Set(@_);
+ return $self->SUPER::_Set(@_);
}
-----------------------------------------------------------------------
More information about the Rt-commit
mailing list