[Rt-commit] rt branch, 4.2/use-apply-globally, created. rt-4.0.8-330-gfd661e5

[Thomas Sibley]

The branch, 4.2/use-apply-globally has been created
        at  fd661e5d76d41a0742c293f97a8aa9221ee60824 (commit)

- Log -----------------------------------------------------------------
commit fd661e5d76d41a0742c293f97a8aa9221ee60824
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Thu Nov 1 15:47:31 2012 -0700

    Use the ApplyGlobally method instead of matching the LookupType directly
    
    ApplyGlobally provides a consistent single place to determine if a CF is
    always global.  This is particularly important for extensions adding new
    LookupTypes which may also be global only.

diff --git a/share/html/Admin/CustomFields/Modify.html b/share/html/Admin/CustomFields/Modify.html
index 0110b7d..d95d034 100644
--- a/share/html/Admin/CustomFields/Modify.html
+++ b/share/html/Admin/CustomFields/Modify.html
@@ -273,7 +273,7 @@ CustomFieldObj => $CustomFieldObj, CustomFieldValueObj => $cfv, ARGSRef => \%ARG
     }
 }
 
-if ( $CustomFieldObj->id && $CustomFieldObj->LookupType =~ /^RT::(?:User|Group)$/ ) {
+if ( $CustomFieldObj->id && $CustomFieldObj->ApplyGlobally ) {
     my ( $ret, $msg );
     my $object = $CustomFieldObj->RecordClassFromLookupType->new( $session{'CurrentUser'} );
 
diff --git a/share/html/Elements/Tabs b/share/html/Elements/Tabs
index 015c2e3..9b20528 100755
--- a/share/html/Elements/Tabs
+++ b/share/html/Elements/Tabs
@@ -346,7 +346,7 @@ my $build_admin_menu = sub {
             $tabs->child( basics           => title => loc('Basics'),       path => "/Admin/CustomFields/Modify.html?id=".$id );
             $tabs->child( 'group-rights'   => title => loc('Group Rights'), path => "/Admin/CustomFields/GroupRights.html?id=" . $id );
             $tabs->child( 'user-rights'    => title => loc('User Rights'),  path => "/Admin/CustomFields/UserRights.html?id=" . $id );
-            unless ( $obj->LookupType =~ /^RT::(?:User|Group)$/ ) {
+            unless ( $obj->ApplyGlobally ) {
                 $tabs->child( 'applies-to' => title => loc('Applies to'),   path => "/Admin/CustomFields/Objects.html?id=" . $id );
             }
         }

-----------------------------------------------------------------------