[Rt-commit] rt branch, 4.2/remove-dashboard-javascript-flag, created. rt-4.0.8-332-g80f6431

[Alex Vandiver]

The branch, 4.2/remove-dashboard-javascript-flag has been created
        at  80f6431bbde14d46bc6778f8c8e3e36e3e29fdd0 (commit)

- Log -----------------------------------------------------------------
commit 80f6431bbde14d46bc6778f8c8e3e36e3e29fdd0
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Sat Nov 3 19:22:14 2012 -0400

    As 1599f0d scrubs javascript in dashboards, remove the flag
    
    The $JavaScript flag was originally introduced in an attempt to cut out
    every javascript insertion during when constructing dashboards --
    however, it did so imperfectly, and was replaced by use of
    HTML::Scrubber in 1599f0d.  The flag was left for backwards
    compatibility; remove it.

diff --git a/share/html/Dashboards/Render.html b/share/html/Dashboards/Render.html
index 59861eb..9f681ae 100644
--- a/share/html/Dashboards/Render.html
+++ b/share/html/Dashboards/Render.html
@@ -47,7 +47,6 @@
 %# END BPS TAGGED BLOCK }}}
 <& /Elements/Header,
     Title => $title,
-    JavaScript => $Preview,
     ShowBar => $Preview,
     Refresh => $Refresh,
 &>
diff --git a/share/html/Elements/Header b/share/html/Elements/Header
index ccdf0f2..cd43053 100755
--- a/share/html/Elements/Header
+++ b/share/html/Elements/Header
@@ -75,9 +75,7 @@
     <link rel="alternate" href="<%$RSSAutoDiscovery%>" type="application/rss+xml" title="RSS RT Search" />
 % }
 
-% if ($JavaScript) {
 <& HeaderJavascript, focus => $Focus, onload => $onload, RichText => $RichText &>
-% }
 
 % my $stylesheet_plugin = "/NoAuth/css/".$style."/InHeader";
 % if ($m->comp_exists($stylesheet_plugin) ) {
@@ -148,7 +146,6 @@ $URL => undef
 $RSSAutoDiscovery => undef
 $onload => undef
 $LinkRel => undef
-$JavaScript => 1
 $SkipDoctype => 0
 $RichText => 1
 </%ARGS>

-----------------------------------------------------------------------