[Rt-commit] rt branch, 4.2/devel-mode-and-testdeps, created. rt-4.0.8-337-gf170046
Alex Vandiver
alexmv at bestpractical.com
Mon Nov 5 18:31:17 EST 2012
The branch, 4.2/devel-mode-and-testdeps has been created
at f17004647522a679a811502ebe775ba179464d43 (commit)
- Log -----------------------------------------------------------------
commit fd2c4a5a03b15f11b422db692ad65bd4dc15d89c
Author: Alex Vandiver <alexmv at bestpractical.com>
Date: Mon Nov 5 18:02:40 2012 -0500
Make Module::Refresh a core dependency
This means that --devel-mode is only necessary for people who intend to
run tests or do other development of RT, but that users who merely
intend to extend RT using Mason, for instance, do not need the extensive
list of dependencies used during testing.
diff --git a/sbin/rt-test-dependencies.in b/sbin/rt-test-dependencies.in
index 3a7b0aa..d5bbcdd 100755
--- a/sbin/rt-test-dependencies.in
+++ b/sbin/rt-test-dependencies.in
@@ -228,6 +228,7 @@ Net::CIDR
Regexp::Common::net::CIDR
Regexp::IPv6
Symbol::Global::Name
+Module::Refresh 0.03
.
$deps{'MASON'} = [ text_to_hash( << '.') ];
@@ -284,7 +285,6 @@ HTML::Form
HTML::TokeParser
WWW::Mechanize 1.52
Test::WWW::Mechanize 1.30
-Module::Refresh 0.03
Test::Expect 0.31
XML::Simple
File::Find
commit a14e3abbfceec6c7d4cd93daf396a557e61d07a8
Author: Alex Vandiver <alexmv at bestpractical.com>
Date: Mon Nov 5 18:05:57 2012 -0500
Rename --devel-mode to --developer, to make break in meaning clear
Previously, --devel-mode both added the dependencies needed for testing
RT, as well as setting the default value of $DevelMode in RT_Config.pm
These actions are orthogonal, as many users wish to enable $DevelMode
but do not need the additional dependencies; and developers may not wish
to run with $DevelMode.
By renaming the option, existing users of --devel-mode will no longer
have the additional dependencies if all they wish is Module::Refresh.
This also makes the setting of $DevelMode in RT_Config.pm no longer
controlled at configure-time, which is an odd action-at-a-distance, as
it means one RT's defaults are malleable from one install to another.
Consistency is improved by forcing users to add it to RT_SiteConfig.pm,
like any other option.
diff --git a/configure.ac b/configure.ac
index ce35320..064b061 100755
--- a/configure.ac
+++ b/configure.ac
@@ -251,19 +251,19 @@ AC_ARG_WITH(apachectl,
APACHECTL=`which apachectl`)
AC_SUBST(APACHECTL)
-dnl RT's "maintainer mode"
-AC_ARG_WITH(devel-mode,[],RT_DEVEL_MODE=$withval,RT_DEVEL_MODE="0")
-AC_ARG_ENABLE(devel-mode,
- AC_HELP_STRING([--enable-devel-mode],
- [Turn on development aids that might hurt you in production]),
- RT_DEVEL_MODE=$enableval,
- RT_DEVEL_MODE=$RT_DEVEL_MODE)
-if test "$RT_DEVEL_MODE" = yes; then
- RT_DEVEL_MODE="1"
+dnl Dependencies for testing and developing RT
+AC_ARG_WITH(developer,[],RT_DEVELOPER=$withval,RT_DEVELOPER="0")
+AC_ARG_ENABLE(developer,
+ AC_HELP_STRING([--enable-developer],
+ [Add dependencies needed for testing and developing RT]),
+ RT_DEVELOPER=$enableval,
+ RT_DEVELOPER=$RT_DEVELOPER)
+if test "$RT_DEVELOPER" = yes; then
+ RT_DEVELOPER="1"
else
- RT_DEVEL_MODE="0"
+ RT_DEVELOPER="0"
fi
-AC_SUBST(RT_DEVEL_MODE)
+AC_SUBST(RT_DEVELOPER)
dnl RT's GraphViz dependency charts
AC_CHECK_LIB([graph],[aginitlib],RT_GRAPHVIZ="1")
diff --git a/etc/RT_Config.pm.in b/etc/RT_Config.pm.in
index 43618c5..3618c47 100755
--- a/etc/RT_Config.pm.in
+++ b/etc/RT_Config.pm.in
@@ -2646,7 +2646,7 @@ be added while the server is running.
=cut
-Set($DevelMode, "@RT_DEVEL_MODE@");
+Set($DevelMode, 0);
=item C<$RecordBaseClass>
diff --git a/sbin/rt-test-dependencies.in b/sbin/rt-test-dependencies.in
index d5bbcdd..7689b14 100755
--- a/sbin/rt-test-dependencies.in
+++ b/sbin/rt-test-dependencies.in
@@ -65,7 +65,7 @@ GetOptions(
'with-MODPERL1', 'with-MODPERL2',
'with-STANDALONE',
- 'with-DEV',
+ 'with-DEVELOPER',
'with-GPG',
'with-ICAL',
@@ -96,7 +96,7 @@ my %default = (
'with-CORE' => 1,
'with-CLI' => 1,
'with-MAILGATE' => 1,
- 'with-DEV' => @RT_DEVEL_MODE@,
+ 'with-DEVELOPER' => @RT_DEVELOPER@,
'with-GPG' => @RT_GPG@,
'with-ICAL' => 1,
'with-SMTP' => 1,
@@ -105,7 +105,7 @@ my %default = (
'with-DASHBOARDS' => 1,
'with-USERLOGO' => 1,
'with-SSL-MAILGATE' => @RT_SSL_MAILGATE@,
- 'with-HTML-DOC' => @RT_DEVEL_MODE@,
+ 'with-HTML-DOC' => @RT_DEVELOPER@,
);
$args{$_} = $default{$_} foreach grep !exists $args{$_}, keys %default;
@@ -278,7 +278,7 @@ Term::ReadLine
Term::ReadKey
.
-$deps{'DEV'} = [ text_to_hash( << '.') ];
+$deps{'DEVELOPER'} = [ text_to_hash( << '.') ];
Email::Abstract
Test::Email
HTML::Form
@@ -675,7 +675,7 @@ list the status of all dependencies, rather than just the missing ones.
libraries needed to support the modperl 2 handler
-=item with-dev
+=item with-developer
tools needed for RT development
commit 197606df5801bc2284e47139bcdcb315fdc90087
Author: Alex Vandiver <alexmv at bestpractical.com>
Date: Mon Nov 5 18:12:20 2012 -0500
Sort dependencies and remove duplicates
diff --git a/sbin/rt-test-dependencies.in b/sbin/rt-test-dependencies.in
index 7689b14..f4802ed 100755
--- a/sbin/rt-test-dependencies.in
+++ b/sbin/rt-test-dependencies.in
@@ -182,77 +182,77 @@ sub text_to_hash {
}
$deps{'CORE'} = [ text_to_hash( << '.') ];
+CSS::Squish 0.06
+Cache::Simple::TimedExpiry
Class::Accessor 0.34
+Class::ReturnValue 0.40
+DBI 1.37
+DBIx::SearchBuilder 1.59
DateTime 0.44
DateTime::Locale 0.40
-Digest::base
+Devel::GlobalDestruction
+Devel::StackTrace 1.19
Digest::MD5 2.27
Digest::SHA
-DBI 1.37
-Class::ReturnValue 0.40
-DBIx::SearchBuilder 1.59
-Text::Template 1.44
+Digest::base
+Email::Address
+Encode 2.39
+File::Glob
File::ShareDir
File::Spec 0.8
+File::Temp 0.19
+HTML::FormatText
HTML::Quoted
HTML::Scrubber 0.08
HTML::TreeBuilder
-HTML::FormatText
-Log::Dispatch 2.23
-Sys::Syslog 0.16
+List::MoreUtils
Locale::Maketext 1.06
-Locale::Maketext::Lexicon 0.32
Locale::Maketext::Fuzzy 0.11
+Locale::Maketext::Lexicon 0.32
+Log::Dispatch 2.23
MIME::Entity 5.425
Mail::Mailer 1.57
-Email::Address
-Text::Wrapper
-Time::ParseDate
-Time::HiRes
-File::Temp 0.19
-Text::Quoted 2.02
-Tree::Simple 1.04
-UNIVERSAL::require
-Regexp::Common
-Scalar::Util
+Module::Refresh 0.03
Module::Versions::Report 1.05
-Cache::Simple::TimedExpiry
-Encode 2.39
-CSS::Squish 0.06
-File::Glob
-Devel::StackTrace 1.19
-Text::Password::Pronounceable
-Devel::GlobalDestruction
-List::MoreUtils
Net::CIDR
+Regexp::Common
Regexp::Common::net::CIDR
Regexp::IPv6
+Scalar::Util
Symbol::Global::Name
-Module::Refresh 0.03
+Sys::Syslog 0.16
+Text::Password::Pronounceable
+Text::Quoted 2.02
+Text::Template 1.44
+Text::Wrapper
+Time::HiRes
+Time::ParseDate
+Tree::Simple 1.04
+UNIVERSAL::require
.
$deps{'MASON'} = [ text_to_hash( << '.') ];
-HTML::Mason 1.43
-Errno
-Digest::MD5 2.27
-CGI::Cookie 1.20
-Storable 2.08
Apache::Session 1.53
-XML::RSS 1.05
-Text::WikiFormat 0.76
+CGI::Cookie 1.20
CSS::Squish 0.06
Devel::StackTrace 1.19
-JSON
+Digest::MD5 2.27
+Errno
+HTML::Mason 1.43
IPC::Run3
+JSON
+Storable 2.08
+Text::WikiFormat 0.76
+XML::RSS 1.05
.
$deps{'PSGI'} = [ text_to_hash( << '.') ];
CGI 3.38
+CGI::Emulate::PSGI
CGI::PSGI 0.12
HTML::Mason::PSGIHandler 0.52
Plack 0.9971
Plack::Handler::Starlet
-CGI::Emulate::PSGI
.
$deps{'MAILGATE'} = [ text_to_hash( << '.') ];
@@ -263,41 +263,40 @@ Pod::Usage
$deps{'SSL-MAILGATE'} = [ text_to_hash( << '.') ];
Crypt::SSLeay
-Net::SSL
-LWP::UserAgent 6.0
LWP::Protocol::https
+LWP::UserAgent 6.0
Mozilla::CA
+Net::SSL
.
$deps{'CLI'} = [ text_to_hash( << '.') ];
Getopt::Long 2.24
-LWP
HTTP::Request::Common
-Text::ParseWords
-Term::ReadLine
+LWP
Term::ReadKey
+Term::ReadLine
+Text::ParseWords
.
$deps{'DEVELOPER'} = [ text_to_hash( << '.') ];
Email::Abstract
-Test::Email
+File::Find
HTML::Form
HTML::TokeParser
-WWW::Mechanize 1.52
-Test::WWW::Mechanize 1.30
-Test::Expect 0.31
-XML::Simple
-File::Find
-Test::Deep 0 # needed for shredder tests
-String::ShellQuote 0 # needed for gnupg-incoming.t
Log::Dispatch::Perl
-Test::Warn
+Plack::Middleware::Test::StashWarnings 0.06
+String::ShellQuote 0 # needed for gnupg-incoming.t
Test::Builder 0.90 # needed for is_passing
+Test::Deep 0 # needed for shredder tests
+Test::Email
+Test::Expect 0.31
+Test::LongString
Test::MockTime
-Log::Dispatch::Perl
+Test::WWW::Mechanize 1.30
Test::WWW::Mechanize::PSGI
-Plack::Middleware::Test::StashWarnings 0.06
-Test::LongString
+Test::Warn
+WWW::Mechanize 1.52
+XML::Simple
.
$deps{'FASTCGI'} = [ text_to_hash( << '.') ];
@@ -366,8 +365,8 @@ Convert::Color
.
$deps{'HTML-DOC'} = [ text_to_hash( <<'.') ];
-Pod::Simple 3.17
HTML::Entities
+Pod::Simple 3.17
.
my %AVOID = (
commit 037e04ad17db163a5c2a9486b7af809c7023532a
Author: Alex Vandiver <alexmv at bestpractical.com>
Date: Mon Nov 5 18:21:17 2012 -0500
Merge core dependencies into one list, and eliminate duplicates
PSGI and MASON are core dependencies which cannot be disabled using
command-line flags; fold them into CORE. Though CLI and MAILGATE are
similarly required, and cannot be disabled using command-line flags,
keep them separate for now, as they are standalone binaries which are
intended to be able to be distributed separately. Keeping a separate
list of their dependencies is thus of use.
diff --git a/sbin/rt-test-dependencies.in b/sbin/rt-test-dependencies.in
index f4802ed..2ca8a21 100755
--- a/sbin/rt-test-dependencies.in
+++ b/sbin/rt-test-dependencies.in
@@ -91,11 +91,9 @@ if ( $args{help} ) {
# Set up defaults
my %default = (
- 'with-MASON' => 1,
- 'with-PSGI' => 1,
'with-CORE' => 1,
'with-CLI' => 1,
- 'with-MAILGATE' => 1,
+ 'with-MAILGATE' => 1,
'with-DEVELOPER' => @RT_DEVELOPER@,
'with-GPG' => @RT_GPG@,
'with-ICAL' => 1,
@@ -182,6 +180,11 @@ sub text_to_hash {
}
$deps{'CORE'} = [ text_to_hash( << '.') ];
+Apache::Session 1.53
+CGI 3.38
+CGI::Cookie 1.20
+CGI::Emulate::PSGI
+CGI::PSGI 0.12
CSS::Squish 0.06
Cache::Simple::TimedExpiry
Class::Accessor 0.34
@@ -197,14 +200,19 @@ Digest::SHA
Digest::base
Email::Address
Encode 2.39
+Errno
File::Glob
File::ShareDir
File::Spec 0.8
File::Temp 0.19
HTML::FormatText
+HTML::Mason 1.43
+HTML::Mason::PSGIHandler 0.52
HTML::Quoted
HTML::Scrubber 0.08
HTML::TreeBuilder
+IPC::Run3
+JSON
List::MoreUtils
Locale::Maketext 1.06
Locale::Maketext::Fuzzy 0.11
@@ -215,46 +223,27 @@ Mail::Mailer 1.57
Module::Refresh 0.03
Module::Versions::Report 1.05
Net::CIDR
+Plack 0.9971
+Plack::Handler::Starlet
Regexp::Common
Regexp::Common::net::CIDR
Regexp::IPv6
Scalar::Util
+Storable 2.08
Symbol::Global::Name
Sys::Syslog 0.16
Text::Password::Pronounceable
Text::Quoted 2.02
Text::Template 1.44
+Text::WikiFormat 0.76
Text::Wrapper
Time::HiRes
Time::ParseDate
Tree::Simple 1.04
UNIVERSAL::require
-.
-
-$deps{'MASON'} = [ text_to_hash( << '.') ];
-Apache::Session 1.53
-CGI::Cookie 1.20
-CSS::Squish 0.06
-Devel::StackTrace 1.19
-Digest::MD5 2.27
-Errno
-HTML::Mason 1.43
-IPC::Run3
-JSON
-Storable 2.08
-Text::WikiFormat 0.76
XML::RSS 1.05
.
-$deps{'PSGI'} = [ text_to_hash( << '.') ];
-CGI 3.38
-CGI::Emulate::PSGI
-CGI::PSGI 0.12
-HTML::Mason::PSGIHandler 0.52
-Plack 0.9971
-Plack::Handler::Starlet
-.
-
$deps{'MAILGATE'} = [ text_to_hash( << '.') ];
Getopt::Long
LWP::UserAgent 6.0
commit 28dd4b97e851afc2cd33fed2460270662fab237c
Author: Alex Vandiver <alexmv at bestpractical.com>
Date: Mon Nov 5 18:29:51 2012 -0500
Rename --with-postgresql to --with-pg, which is what the makefile calls
diff --git a/sbin/rt-test-dependencies.in b/sbin/rt-test-dependencies.in
index 2ca8a21..757dd90 100755
--- a/sbin/rt-test-dependencies.in
+++ b/sbin/rt-test-dependencies.in
@@ -60,7 +60,7 @@ my @orig_argv = @ARGV;
GetOptions(
\%args, 'v|verbose',
'install!', 'with-MYSQL',
- 'with-POSTGRESQL|with-pg|with-pgsql', 'with-SQLITE',
+ 'with-PG', 'with-SQLITE',
'with-ORACLE', 'with-FASTCGI',
'with-MODPERL1', 'with-MODPERL2',
'with-STANDALONE',
@@ -311,7 +311,7 @@ $deps{'ORACLE'} = [ text_to_hash( << '.') ];
DBD::Oracle
.
-$deps{'POSTGRESQL'} = [ text_to_hash( << '.') ];
+$deps{'PG'} = [ text_to_hash( << '.') ];
DBD::Pg 1.43
.
@@ -639,7 +639,7 @@ list the status of all dependencies, rather than just the missing ones.
database interface for mysql
-=item --with-postgresql
+=item --with-pg
database interface for postgresql
commit f17004647522a679a811502ebe775ba179464d43
Author: Alex Vandiver <alexmv at bestpractical.com>
Date: Mon Nov 5 18:30:20 2012 -0500
Minor reformatting of options and POD
diff --git a/sbin/rt-test-dependencies.in b/sbin/rt-test-dependencies.in
index 757dd90..7c2cad9 100755
--- a/sbin/rt-test-dependencies.in
+++ b/sbin/rt-test-dependencies.in
@@ -59,11 +59,9 @@ my %deps;
my @orig_argv = @ARGV;
GetOptions(
\%args, 'v|verbose',
- 'install!', 'with-MYSQL',
- 'with-PG', 'with-SQLITE',
- 'with-ORACLE', 'with-FASTCGI',
- 'with-MODPERL1', 'with-MODPERL2',
- 'with-STANDALONE',
+ 'install!',
+ 'with-MYSQL', 'with-PG', 'with-SQLITE', 'with-ORACLE',
+ 'with-FASTCGI', 'with-MODPERL1', 'with-MODPERL2', 'with-STANDALONE',
'with-DEVELOPER',
@@ -637,35 +635,37 @@ list the status of all dependencies, rather than just the missing ones.
=item --with-mysql
- database interface for mysql
+database interface for mysql
=item --with-pg
- database interface for postgresql
+database interface for postgresql
-=item with-oracle
-
- database interface for oracle
+=item --with-oracle
+
+database interface for oracle
+
+=item --with-sqlite
-=item with-sqlite
+database interface and driver for sqlite (unsupported)
- database interface and driver for sqlite (unsupported)
+=item --with-fastcgi
-=item with-fastcgi
+libraries needed to support the fastcgi handler
- libraries needed to support the fastcgi handler
+=item --with-modperl1
-=item with-modperl1
+libraries needed to support the modperl 1 handler
- libraries needed to support the modperl 1 handler
+=item --with-modperl2
-=item with-modperl2
+libraries needed to support the modperl 2 handler
- libraries needed to support the modperl 2 handler
+=item --with-developer
-=item with-developer
+tools needed for RT development
- tools needed for RT development
+=item
=back
-----------------------------------------------------------------------
More information about the Rt-commit
mailing list