[Rt-commit] rt branch, 4.0/status-selector, updated. rt-4.0.8-151-ge9d1a76

[Thomas Sibley]

The branch, 4.0/status-selector has been updated
       via  e9d1a7619833beb78ad702849f28843713cef868 (commit)
       via  d36d93b332b126a7e15aaff91f933e9d48c93225 (commit)
      from  4b3351b4c2bc573d2d93fc3886bf322d4515461d (commit)

Summary of changes:
 t/web/query_builder_queue_limits.t | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

- Log -----------------------------------------------------------------
commit d36d93b332b126a7e15aaff91f933e9d48c93225
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Wed Nov 7 10:00:38 2012 -0800

    Tests: Useful diagnostics for failed status selector tests

diff --git a/t/web/query_builder_queue_limits.t b/t/web/query_builder_queue_limits.t
index f583d64..8f844bb 100644
--- a/t/web/query_builder_queue_limits.t
+++ b/t/web/query_builder_queue_limits.t
@@ -79,7 +79,7 @@ my $status_input = $form->find_input('ValueOfStatus');
 my @statuses     = sort $status_input->possible_values;
 is_deeply(
     \@statuses, [ '', qw/initial new open rejected resolved stalled/], 'found all statuses'
-);
+) or diag "Statuses are: ", explain \@statuses;
 
 my $owner_input = $form->find_input('ValueOfActor');
 my @owners     = sort $owner_input->possible_values;
@@ -128,7 +128,7 @@ is_deeply(
     \@statuses,
     [ '', qw/initial new open rejected resolved stalled/ ],
     'found all statuses again'
-);
+) or diag "Statuses are: ", explain \@statuses;
 $owner_input = $form->find_input('ValueOfActor');
 @owners     = sort $owner_input->possible_values;
 is_deeply(
@@ -152,7 +152,7 @@ $status_input = $form->find_input('ValueOfStatus');
 is_deeply(
     \@statuses, [ '', qw/initial new open rejected resolved stalled/],
     'found all statuses'
-);
+) or diag "Statuses are: ", explain \@statuses;
 $owner_input = $form->find_input('ValueOfActor');
 @owners     = sort $owner_input->possible_values;
 is_deeply(
@@ -175,7 +175,7 @@ is_deeply(
     \@statuses,
     [ '', qw/initial new open rejected resolved stalled/ ],
     'found all statuses'
-);
+) or diag "Statuses are: ", explain \@statuses;
 $owner_input = $form->find_input('ValueOfActor');
 @owners     = sort $owner_input->possible_values;
 is_deeply(

commit e9d1a7619833beb78ad702849f28843713cef868
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Wed Nov 7 10:07:53 2012 -0800

    Tests: Statuses may now show up multiple times in the selector widget
    
    Checking for the duplicates is better than weeding them out since it
    ensures the grouping logic is working correctly.  Unfortunately
    HTML::Form (and hence WWW::Mechanize) provides no means to check
    <optgroup> easily.  Ideally we'd check the presence and order of the
    combined keys "<lifecycle name>-<status>".
    
    Tests now pass.

diff --git a/t/web/query_builder_queue_limits.t b/t/web/query_builder_queue_limits.t
index 8f844bb..332cc93 100644
--- a/t/web/query_builder_queue_limits.t
+++ b/t/web/query_builder_queue_limits.t
@@ -78,7 +78,7 @@ ok( !$form->find_input("ValueOf'CF.{foo_cf}'"), 'no foo_cf by default' );
 my $status_input = $form->find_input('ValueOfStatus');
 my @statuses     = sort $status_input->possible_values;
 is_deeply(
-    \@statuses, [ '', qw/initial new open rejected resolved stalled/], 'found all statuses'
+    \@statuses, [ '', qw/initial new open open rejected resolved resolved stalled/], 'found all statuses'
 ) or diag "Statuses are: ", explain \@statuses;
 
 my $owner_input = $form->find_input('ValueOfActor');
@@ -126,7 +126,7 @@ $status_input = $form->find_input('ValueOfStatus');
 @statuses     = sort $status_input->possible_values;
 is_deeply(
     \@statuses,
-    [ '', qw/initial new open rejected resolved stalled/ ],
+    [ '', qw/initial new open open rejected resolved resolved stalled/ ],
     'found all statuses again'
 ) or diag "Statuses are: ", explain \@statuses;
 $owner_input = $form->find_input('ValueOfActor');
@@ -150,7 +150,7 @@ ok( !$form->find_input("ValueOf'CF.{general_cf}'"), 'no general_cf' );
 $status_input = $form->find_input('ValueOfStatus');
 @statuses     = sort $status_input->possible_values;
 is_deeply(
-    \@statuses, [ '', qw/initial new open rejected resolved stalled/],
+    \@statuses, [ '', qw/initial new open open rejected resolved resolved stalled/],
     'found all statuses'
 ) or diag "Statuses are: ", explain \@statuses;
 $owner_input = $form->find_input('ValueOfActor');
@@ -173,7 +173,7 @@ $status_input = $form->find_input('ValueOfStatus');
 @statuses     = sort $status_input->possible_values;
 is_deeply(
     \@statuses,
-    [ '', qw/initial new open rejected resolved stalled/ ],
+    [ '', qw/initial new open open rejected resolved resolved stalled/ ],
     'found all statuses'
 ) or diag "Statuses are: ", explain \@statuses;
 $owner_input = $form->find_input('ValueOfActor');

-----------------------------------------------------------------------