[Rt-commit] rt branch, 4.0/clean-jumbo-message-box, created. rt-4.0.7-58-g92cefb5

Ruslan Zakirov ruz at bestpractical.com
Thu Nov 22 11:46:41 EST 2012


The branch, 4.0/clean-jumbo-message-box has been created
        at  92cefb5d449037ad8b07f4a5f74df1b3e85c7352 (commit)

- Log -----------------------------------------------------------------
commit 92cefb5d449037ad8b07f4a5f74df1b3e85c7352
Author: Ruslan Zakirov <ruz at bestpractical.com>
Date:   Wed Mar 2 14:52:50 2011 +0300

    self-redirect Jumbo page after update
    
    If we don't do this then for non English UI
    message box keeps previous message and
    submiting the form result in a duplicated
    message. Existing protection was based on
    parsing results messages with a regexp, so
    worked only for English UI.
    
    Sure, without this change refresh resubmits
    previous request.

diff --git a/share/html/Ticket/ModifyAll.html b/share/html/Ticket/ModifyAll.html
index 8619cd5..36d4dc5 100755
--- a/share/html/Ticket/ModifyAll.html
+++ b/share/html/Ticket/ModifyAll.html
@@ -112,7 +112,7 @@
   <tr>
     <td class="labeltop"><&|/l&>Content</&>:</td>
     <td class="entry">
-% if (defined $ARGS{UpdateContent} && length($ARGS{UpdateContent} && !grep { /Message recorded/ } @results )) {
+% if ( defined $ARGS{UpdateContent} && length $ARGS{UpdateContent} ) {
     <& /Elements/MessageBox, Name=>"UpdateContent", Default=>$ARGS{UpdateContent}, IncludeSignature => 0 &>
 % } else {
     <& /Elements/MessageBox, Name=>"UpdateContent", QuoteTransaction=>$ARGS{QuoteTransaction} &>
@@ -214,6 +214,12 @@ unless ($OnlySearchForPeople or $OnlySearchForGroup or $ARGS{'AddMoreAttach'} )
 
 $Ticket->ApplyTransactionBatch;
 
+MaybeRedirectForResults(
+    Actions   => \@results,
+    Path      => "/Ticket/ModifyAll.html",
+    Arguments => { id => $Ticket->id },
+);
+
 # If they've gone and moved the ticket to somewhere they can't see, etc...
 # TODO: display the results, even if we can't display the ticket.
 

-----------------------------------------------------------------------


More information about the Rt-commit mailing list