[Rt-commit] rt branch, 4.0/rest-fix-requestors, created. rt-4.0.8-182-g7e9a291

[? sunnavy]

The branch, 4.0/rest-fix-requestors has been created
        at  7e9a2913b34a29b0064f1c1c335c1f523baead91 (commit)

- Log -----------------------------------------------------------------
commit 4c12c9aed552954cbc24afe4643238c4b361878a
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Wed Nov 21 22:56:50 2012 +0800

    allow "requestors" because it's a valid field
    
    in 4.0/cli-create-ticket-with-unknown-field, we added extra guard to
    throw errors if there are some fields unknown. we missed "requestors"
    field there, which is actually valid.
    
    see also #21552

diff --git a/share/html/REST/1.0/Forms/ticket/default b/share/html/REST/1.0/Forms/ticket/default
index ca82373..ea420cb 100644
--- a/share/html/REST/1.0/Forms/ticket/default
+++ b/share/html/REST/1.0/Forms/ticket/default
@@ -167,7 +167,7 @@ else {
             elsif (lc $k eq 'text') {
                 $text = delete $data{$k};
             }
-            elsif ( lc $k ne 'id' ) {
+            elsif ( $k !~ /^(?:id|requestors)$/i ) {
                 $e = 1;
                 push @$o, $k;
                 push(@comments, "# $k: Unknown field");

commit 7e9a2913b34a29b0064f1c1c335c1f523baead91
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Thu Nov 22 00:02:19 2012 +0800

    test for requestors field from rest

diff --git a/t/web/command_line_with_unknown_field.t b/t/web/command_line_with_unknown_field.t
index c2f2724..6afad8a 100644
--- a/t/web/command_line_with_unknown_field.t
+++ b/t/web/command_line_with_unknown_field.t
@@ -2,7 +2,7 @@ use strict;
 use warnings;
 use File::Spec ();
 use Test::Expect;
-use RT::Test tests => 17, actual_server => 1;
+use RT::Test tests => 21, actual_server => 1;
 my ($baseurl, $m) = RT::Test->started_ok;
 my $rt_tool_path = "$RT::BinPath/rt";
 
@@ -37,6 +37,15 @@ expect_send("edit ticket/$ticket_id set homer=simpson", 'set unknown field');
 expect_like(qr/homer: Unknown field/, 'homer is unknown field');
 expect_like(qr/homer: simpson/, 'the value we set for homer is shown too');
 
+expect_send(
+    q{create -t ticket set requestors='foo at example.com, bar at example.com'},
+    "create ticket with field 'requestors'" );
+expect_like(qr/Ticket \d+ created/, "Created the ticket");
+expect_handle->before() =~ /Ticket (\d+) created/;
+$ticket_id = $1;
+expect_send("show ticket/$ticket_id", 'check requestors');
+expect_like(qr/From: (?:foo\@example\.com, bar\@example\.com|bar\@example\.com, foo\@example\.com)/, "requestors are set correctly");
+
 expect_quit();
 
 # you may encounter warning like Use of uninitialized value $ampm

-----------------------------------------------------------------------