[Rt-commit] rtir branch, 2.9/error-message-on-251-upgrade, created. 3.0.0rc1-15-gc240b25

[Jim Brandt]

The branch, 2.9/error-message-on-251-upgrade has been created
        at  c240b252bc83d33ebe65b70f2a3d8cbe30445e57 (commit)

- Log -----------------------------------------------------------------
commit c240b252bc83d33ebe65b70f2a3d8cbe30445e57
Author: Jim Brandt <jbrandt at bestpractical.com>
Date:   Tue Oct 2 14:47:04 2012 -0400

    Update debug message in content to warn on success
    
    The previous debug message in the content file for the 2.5.1
    upgrade issued an error even when the targeted custom field
    was successfully updated. This was a confusing message since it
    said both "error" and "success."
    
    Update to warn on success so users still see that key custom
    fields are changed. Still error on failure.

diff --git a/etc/upgrade/2.5.1/content b/etc/upgrade/2.5.1/content
index be1ccc4..ee8265e 100644
--- a/etc/upgrade/2.5.1/content
+++ b/etc/upgrade/2.5.1/content
@@ -18,7 +18,13 @@ my %special_rename = (
             $new = $special_rename{ lc $new } || $new;
 
             my ($status, $msg) = $cf->SetName( $new );
-            $RT::Logger->error("Couldn't rename custom field '$name': $msg");
+
+            if ( $status ){
+                $RT::Logger->warning("RTIR custom field $name renamed: $msg");
+            }
+            else{
+                $RT::Logger->error("Couldn't rename custom field '$name': $msg");
+            }
         }
     },
 );

-----------------------------------------------------------------------