[Rt-commit] rt branch, 4.0/collection-list-layout-in-ie, created. rt-4.0.7-61-gf10490e

[Thomas Sibley]

The branch, 4.0/collection-list-layout-in-ie has been created
        at  f10490e1eb64c9a2afb0cb40fe74a32f7b06eb2e (commit)

- Log -----------------------------------------------------------------
commit 644407a8078d9b20bd1ae82d9a37c5412fe28807
Author: Christian Loos <cloos at netcologne.de>
Date:   Tue Sep 25 14:47:26 2012 +0200

    re-add attributes to fix IE layout
    
    We still need border, cellspacing and cellpadding attributes to show the
    collection list in IE (at least IE7) in the same layout as in other
    browsers.
    
    This partly reverts commit f5aa30c9.

diff --git a/share/html/Elements/CollectionList b/share/html/Elements/CollectionList
index 2d1817f..e245da8 100644
--- a/share/html/Elements/CollectionList
+++ b/share/html/Elements/CollectionList
@@ -111,7 +111,7 @@ if ($Class =~ /::/) { # older passed in value
     $Class =~ s/:/_/g;
 }
 
-$m->out('<table class="' .
+$m->out('<table border="0" cellspacing="0" cellpadding="1" class="' .
 	($Collection->isa('RT::Tickets') ? 'ticket-list' : 'collection') . ' collection-as-table">');
 
 if ( $ShowHeader ) {

commit f10490e1eb64c9a2afb0cb40fe74a32f7b06eb2e
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Tue Oct 23 12:47:08 2012 -0700

    Remove the IE-specific need for two <table> attributes on collection lists
    
    The only reason IE padding was wonky without the cellpadding attribute
    was because our stylesheet set up different padding for IE.  The blanket
    padding is seemingly unnecessary.
    
    The border="0" attribute is unnecessary since a border is set in CSS.
    
    Only cellspacing is out of the reach of CSS in < IE8 because
    border-spacing isn't supported.
    
    Less hardcoded attributes in HTML means more flexibility for CSS down the
    road.  While this is effectively a no-op commit in terms of rendering,
    it's useful to avoid reinstating the two extra <table> attributes.

diff --git a/share/html/Elements/CollectionList b/share/html/Elements/CollectionList
index e245da8..c41c767 100644
--- a/share/html/Elements/CollectionList
+++ b/share/html/Elements/CollectionList
@@ -111,7 +111,7 @@ if ($Class =~ /::/) { # older passed in value
     $Class =~ s/:/_/g;
 }
 
-$m->out('<table border="0" cellspacing="0" cellpadding="1" class="' .
+$m->out('<table cellspacing="0" class="' .
 	($Collection->isa('RT::Tickets') ? 'ticket-list' : 'collection') . ' collection-as-table">');
 
 if ( $ShowHeader ) {
diff --git a/share/html/NoAuth/css/aileron/msie.css b/share/html/NoAuth/css/aileron/msie.css
index c5c091d..c2a8bcf 100644
--- a/share/html/NoAuth/css/aileron/msie.css
+++ b/share/html/NoAuth/css/aileron/msie.css
@@ -137,14 +137,6 @@ div#nav li.last {
     margin-right: auto;
 }
 
-th.collection-as-table {
-    padding: 0.25em;
-}
-
-table.queue-summary td, td.collection-as-table {
-    padding: 0.25em;
-}
-
 .titlebox-title {
     position: relative;
 }
diff --git a/share/html/NoAuth/css/ballard/msie.css b/share/html/NoAuth/css/ballard/msie.css
index ca2676f..034d9ba 100644
--- a/share/html/NoAuth/css/ballard/msie.css
+++ b/share/html/NoAuth/css/ballard/msie.css
@@ -173,14 +173,6 @@ div#nav li.last {
     margin-right: auto;
 }
 
-th.collection-as-table {
-    padding: 0.25em;
-}
-
-table.queue-summary td, td.collection-as-table {
-    padding: 0.25em;
-}
-
  .titlebox-title {
     position: relative;
 }
diff --git a/share/html/NoAuth/css/web2/msie.css b/share/html/NoAuth/css/web2/msie.css
index 81b31e4..ef8ba3b 100644
--- a/share/html/NoAuth/css/web2/msie.css
+++ b/share/html/NoAuth/css/web2/msie.css
@@ -178,14 +178,6 @@ div#nav li.last {
     margin-right: auto;
 }
 
-th.collection-as-table {
-    padding: 0.25em;
-}
-
-table.queue-summary td, td.collection-as-table {
-    padding: 0.25em;
-}
-
  .titlebox-title {
     position: relative;
 }

-----------------------------------------------------------------------