[Rt-commit] rt branch, 4.0/non-character-scrubber-error, updated. rt-4.0.6-255-gcf4ce8f

Thomas Sibley trs at bestpractical.com
Mon Oct 29 15:51:52 EDT 2012


The branch, 4.0/non-character-scrubber-error has been updated
       via  cf4ce8ff161d6ef853cb1bcf337d92ed095922be (commit)
      from  b5a67b12cad23f17587ed005057f1e0e27bd3147 (commit)

Summary of changes:
 t/web/scrub.t | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

- Log -----------------------------------------------------------------
commit cf4ce8ff161d6ef853cb1bcf337d92ed095922be
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Mon Oct 29 12:50:35 2012 -0700

    Use is() rather than is_string() to avoid the fatal error from Test::LongString
    
    Test::LongString uses regexes, and trips on the same bug we're testing
    our solution to!

diff --git a/t/web/scrub.t b/t/web/scrub.t
index 5dab3f9..20b9c6e 100644
--- a/t/web/scrub.t
+++ b/t/web/scrub.t
@@ -46,12 +46,12 @@ use Test::LongString;
     my $expected = q[Some contenthere];
     my $got = eval{scrub_html($html)};
     ok(!$@, "Testing U+FFFF didn't die");
-    is_string($got, $expected, "U+FFFF non-character");
+    is($got, $expected, "U+FFFF non-character");
 
     # This may die _hard_, escaping even the eval.
     $got = eval{scrub_html("<p>content</p>")};
     ok(!$@, "Later uninteresting calls also don't die");
-    is_string($got, "<p>content</p>", "Later uninteresting calls return the right value");
+    is($got, "<p>content</p>", "Later uninteresting calls return the right value");
 }
 
 sub scrub_html {

-----------------------------------------------------------------------


More information about the Rt-commit mailing list