[Rt-commit] rt branch, 4.0/not-escape-in-build-format-string, created. rt-4.0.7-58-g9ba85ba
? sunnavy
sunnavy at bestpractical.com
Tue Sep 11 10:35:48 EDT 2012
The branch, 4.0/not-escape-in-build-format-string has been created
at 9ba85baab99419a26c583a87f9d235d54465954f (commit)
- Log -----------------------------------------------------------------
commit 9ba85baab99419a26c583a87f9d235d54465954f
Author: sunnavy <sunnavy at bestpractical.com>
Date: Tue Sep 11 22:24:20 2012 +0800
don't not escape in BuildFormatString
it's not necessary and would cause double-escape bug(#17002)
diff --git a/share/html/Search/Elements/BuildFormatString b/share/html/Search/Elements/BuildFormatString
index 5ee09cf..ccec38d 100644
--- a/share/html/Search/Elements/BuildFormatString
+++ b/share/html/Search/Elements/BuildFormatString
@@ -229,8 +229,7 @@ foreach my $field (@seen) {
next unless $field;
my $row = "'";
$row .= $field->{'Prefix'} if defined $field->{'Prefix'};
- $row .= "__" . ($field->{'Column'} =~ m/\(/ ? $field->{'Column'} # func, don't escape
- : $m->interp->apply_escapes( $field->{'Column'}, 'h' )) . "__"
+ $row .= "__$field->{'Column'}__"
unless ( $field->{'Column'} eq "<blank>" );
$row .= $field->{'Suffix'} if defined $field->{'Suffix'};
$row .= "'";
-----------------------------------------------------------------------
More information about the Rt-commit
mailing list