[Rt-commit] rt branch, 4.0/log-resolver-failures, created. rt-4.0.11-37-g6a3007a

[Thomas Sibley]

The branch, 4.0/log-resolver-failures has been created
        at  6a3007a87c1c176d76aed8a44067f6df9020c5d8 (commit)

- Log -----------------------------------------------------------------
commit 6a3007a87c1c176d76aed8a44067f6df9020c5d8
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Thu Apr 11 14:13:59 2013 -0700

    Warn on failures to create RT::URI::* resolver objects
    
    Otherwise compilation errors and the like are hidden in $@ never to be
    seen by human eyes.
    
    Errors locating the RT/URI/*.pm file itself are ignored so as not to
    fill the logs with noise on normal http, https, ftp, etc. links.

diff --git a/lib/RT/URI.pm b/lib/RT/URI.pm
index c0958ca..ff19365 100644
--- a/lib/RT/URI.pm
+++ b/lib/RT/URI.pm
@@ -199,6 +199,8 @@ sub _GetResolver {
     if ($resolver) {
         $self->{'resolver'} = $resolver;
     } else {
+        RT->Logger->warning("Failed to create new resolver object for scheme '$scheme': $@")
+            if $@ !~ m{Can't locate RT/URI/\Q$scheme\E};
         $self->{'resolver'} = RT::URI::base->new($self->CurrentUser); 
     }
 

-----------------------------------------------------------------------