[Rt-commit] rt branch, 4.0/delete-system-branded-subject-tag, created. rt-4.0.11-60-g7996ae7
? sunnavy
sunnavy at bestpractical.com
Tue Aug 20 18:16:52 EDT 2013
The branch, 4.0/delete-system-branded-subject-tag has been created
at 7996ae776d9522c63cb6da10dd9f3612cc0d6af5 (commit)
- Log -----------------------------------------------------------------
commit 2573218dda5a5cf426e46264ac34e0ed927fed3b
Author: sunnavy <sunnavy at bestpractical.com>
Date: Wed Apr 17 21:51:39 2013 +0800
clean up global BrandedSubjectTag, which we missed in 3.9.7 upgrade script
diff --git a/etc/upgrade/4.0.12/content b/etc/upgrade/4.0.12/content
new file mode 100644
index 0000000..5a3c864
--- /dev/null
+++ b/etc/upgrade/4.0.12/content
@@ -0,0 +1,11 @@
+ at Initial = (
+ sub {
+ my $attr = RT->System->FirstAttribute('BrandedSubjectTag');
+ return 1 unless $attr;
+ my ( $status, $msg ) = $attr->Delete;
+ unless ( $status ) {
+ RT->Logger->error("Couldn't delete System BrandedSubjectTag: $msg");
+ }
+ return 1;
+ },
+);
commit 7996ae776d9522c63cb6da10dd9f3612cc0d6af5
Author: sunnavy <sunnavy at bestpractical.com>
Date: Wed Aug 21 06:14:41 2013 +0800
no need 3.8-branded-queues-extension any more
because it's replaced by 3.9.7 upgrade content
diff --git a/.gitignore b/.gitignore
index 9707931..dacaee7 100644
--- a/.gitignore
+++ b/.gitignore
@@ -2,7 +2,6 @@
/bin/rt-mailgate
/bin/rt
/etc/RT_Config.pm
-/etc/upgrade/3.8-branded-queues-extension
/etc/upgrade/3.8-ical-extension
/etc/upgrade/split-out-cf-categories
/etc/upgrade/generate-rtaddressregexp
diff --git a/configure.ac b/configure.ac
index ce35320..42a6bd9 100755
--- a/configure.ac
+++ b/configure.ac
@@ -407,7 +407,6 @@ dnl Configure the output files, and generate them.
dnl Binaries that should be +x
AC_CONFIG_FILES([
- etc/upgrade/3.8-branded-queues-extension
etc/upgrade/3.8-ical-extension
etc/upgrade/split-out-cf-categories
etc/upgrade/generate-rtaddressregexp
diff --git a/docs/UPGRADING-3.8 b/docs/UPGRADING-3.8
index cfe01df..d659c11 100644
--- a/docs/UPGRADING-3.8
+++ b/docs/UPGRADING-3.8
@@ -167,13 +167,6 @@ Change this line to read:
"There is no need to reply to this message right now. Your ticket has
been assigned an ID of { $Ticket->SubjectTag }."
-If you were previously using RT::Extension::BrandedQueues, you MUST uninstall
-it before upgrading. In addition, you must run the
-'etc/upgrade/3.8-branded-queues-extension' perl script. This will
-convert the extension's configuration into the new format. Finally, in
-templates where you were using the Tag method ($Ticket->QueueObj->Tag),
-you will need to replace it with $Ticket->SubjectTag
-
RT::Action::LinearEscalate extension has been integrated into core, so you
MUST uninstall it before upgrading.
diff --git a/etc/upgrade/3.8-branded-queues-extension.in b/etc/upgrade/3.8-branded-queues-extension.in
deleted file mode 100755
index 7fb28c5..0000000
--- a/etc/upgrade/3.8-branded-queues-extension.in
+++ /dev/null
@@ -1,95 +0,0 @@
-#!@PERL@
-# BEGIN BPS TAGGED BLOCK {{{
-#
-# COPYRIGHT:
-#
-# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
-# <sales at bestpractical.com>
-#
-# (Except where explicitly superseded by other copyright notices)
-#
-#
-# LICENSE:
-#
-# This work is made available to you under the terms of Version 2 of
-# the GNU General Public License. A copy of that license should have
-# been provided with this software, but in any event can be snarfed
-# from www.gnu.org.
-#
-# This work is distributed in the hope that it will be useful, but
-# WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
-# General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with this program; if not, write to the Free Software
-# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
-# 02110-1301 or visit their web page on the internet at
-# http://www.gnu.org/licenses/old-licenses/gpl-2.0.html.
-#
-#
-# CONTRIBUTION SUBMISSION POLICY:
-#
-# (The following paragraph is not intended to limit the rights granted
-# to you to modify and distribute this software under the terms of
-# the GNU General Public License and is only of importance to you if
-# you choose to contribute your changes and enhancements to the
-# community by submitting them to Best Practical Solutions, LLC.)
-#
-# By intentionally submitting any modifications, corrections or
-# derivatives to this work, or any other work intended for use with
-# Request Tracker, to Best Practical Solutions, LLC, you confirm that
-# you are the copyright holder for those contributions and you grant
-# Best Practical Solutions, LLC a nonexclusive, worldwide, irrevocable,
-# royalty-free, perpetual, license to use, copy, create derivative
-# works based on those contributions, and sublicense and distribute
-# those contributions and any derivatives thereof.
-#
-# END BPS TAGGED BLOCK }}}
-use strict;
-use warnings;
-
-use lib "@LOCAL_LIB_PATH@";
-use lib "@RT_LIB_PATH@";
-
-
-use RT;
-RT::LoadConfig();
-RT::Init();
-
-use RT::Queues;
-
-my $queues = RT::Queues->new( RT->SystemUser );
-$queues->UnLimit();
-while ( my $queue = $queues->Next ) {
- print "Processing queue ". ($queue->Name || $queue->id) ."...\n";
- my $old_attr = $queue->FirstAttribute('BrandedSubjectTag');
- unless ( $old_attr ) {
- print "\thas no old-style subject tag. skipping\n";
- next;
- }
- my $old_value = $old_attr->Content;
- unless ( $old_value ) {
- print "\thas empty old-style subject tag\n";
- } else {
- my ($status, $msg) = $queue->SetSubjectTag( $old_value );
- unless ( $status ) {
- print STDERR "\tERROR. Couldn't set tag: $msg\n";
- next;
- } else {
- print "\thave set new-style subject tag to '$old_value'\n";
- }
- }
-
- my ($status, $msg) = $queue->DeleteAttribute('BrandedSubjectTag');
- unless ( $status ) {
- print STDERR "\tERROR. Couldn't delete old-style tag: $msg\n";
- next;
- } else {
- print "\tdeleted old-style tag entry\n";
- }
- print "\tDONE\n";
-}
-
-exit 0;
-
-----------------------------------------------------------------------
More information about the Rt-commit
mailing list