[Rt-commit] rt branch, master, updated. rt-4.1.19-82-ge2f6a26

Thomas Sibley trs at bestpractical.com
Thu Aug 29 15:18:01 EDT 2013


The branch, master has been updated
       via  e2f6a26816230926f945abd78af255f245d3c5f3 (commit)
      from  bc208823480ccbf82b664a1460a739e0fc60a334 (commit)

Summary of changes:
 lib/RT/Attachment.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

- Log -----------------------------------------------------------------
commit e2f6a26816230926f945abd78af255f245d3c5f3
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Thu Aug 29 11:26:46 2013 -0700

    Ensure the empty collection restriction applies via a separate subclause
    
    Otherwise the id=0 limit can be OR'd with another limit leading to a
    non-empty collection.  This commit should have been part of fbf575d.

diff --git a/lib/RT/Attachment.pm b/lib/RT/Attachment.pm
index d7a1af5..2755992 100644
--- a/lib/RT/Attachment.pm
+++ b/lib/RT/Attachment.pm
@@ -326,7 +326,7 @@ sub Siblings {
         $siblings->Limit( FIELD => 'id', OPERATOR => '!=', VALUE => $self->Id );
     } else {
         # Ensure emptiness
-        $siblings->Limit( FIELD => 'id', VALUE => 0 );
+        $siblings->Limit( SUBCLAUSE => 'empty', FIELD => 'id', VALUE => 0 );
     }
     return $siblings;
 }

-----------------------------------------------------------------------


More information about the Rt-commit mailing list