[Rt-commit] rt branch, 4.0/stable-dashboard-edit, created. rt-4.0.18-118-ga849f25

[Alex Vandiver]

The branch, 4.0/stable-dashboard-edit has been created
        at  a849f253858d5c8156b6c515dae63c456e8f135a (commit)

- Log -----------------------------------------------------------------
commit a849f253858d5c8156b6c515dae63c456e8f135a
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Thu Dec 12 13:34:55 2013 -0500

    Ensure that panes are displayed in a stable order
    
    'keys' on a hash is no longer stable in recent versions of Perl.  As
    such, the display order of the panes (as pushed onto @panes at the end
    of the block) was no longer stable.  This caused the Sidebar and Body
    sections to randomly flip back and forth as a portlet was moved up and
    down in them, or other edits were made.
    
    Sort the panes by name, to ensure consistent display order.

diff --git a/share/html/Dashboards/Queries.html b/share/html/Dashboards/Queries.html
index 2b0a73e..c66c386 100644
--- a/share/html/Dashboards/Queries.html
+++ b/share/html/Dashboards/Queries.html
@@ -190,7 +190,7 @@ $m->callback(
 );
 
 my @panes;
-for my $pane (keys %pane_name) {
+for my $pane (sort keys %pane_name) {
     my $sel = $m->comp(
         '/Widgets/SelectionBox:new',
         Action      => 'Queries.html',

-----------------------------------------------------------------------